* [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" [not found] <20221117114818.v7.1.If7926fcbad397bc6990dd725690229bed403948c@changeid> @ 2022-11-17 18:48 ` Mark Hasemeyer 2022-11-18 5:44 ` Tzung-Bi Shih ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: Mark Hasemeyer @ 2022-11-17 18:48 UTC (permalink / raw) To: LKML Cc: Raul Rangel, Mark Hasemeyer, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Lee Jones, Rob Herring, chrome-platform, devicetree Add DT compatible string in Documentation/devicetree/bindings/mfd/cros_ec.txt Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> Signed-off-by: Mark Hasemeyer <markhas@chromium.org> --- Changes in v7: - No change Changes in v6: - No change Changes in v5: - No change Changes in v4: - Changes in commit message. Changes in v3: - Rebased changes on google,cros-ec.yaml Changes in v2: - No change --- .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index 04962bb29576e..26787e4574b8d 100644 --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml @@ -28,6 +28,9 @@ properties: - description: For implementations of the EC is connected through RPMSG. const: google,cros-ec-rpmsg + - description: + For implementations of the EC is connected through UART. + const: google,cros-ec-uart controller-data: description: @@ -222,4 +225,12 @@ examples: compatible = "google,cros-ec-rpmsg"; }; }; + + # Example for UART + - | + uart0 { + cros-ec { + compatible = "google,cros-ec-uart"; + }; + }; ... -- 2.38.1.584.g0f3c55d4c2-goog ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-17 18:48 ` [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Mark Hasemeyer @ 2022-11-18 5:44 ` Tzung-Bi Shih 2022-11-18 8:59 ` Lee Jones 2022-11-18 12:42 ` Guenter Roeck 2022-11-18 12:49 ` Krzysztof Kozlowski 2 siblings, 1 reply; 8+ messages in thread From: Tzung-Bi Shih @ 2022-11-18 5:44 UTC (permalink / raw) To: Mark Hasemeyer Cc: LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Lee Jones, Rob Herring, chrome-platform, devicetree On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt The patch doesn't apply. Please rebase it. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-18 5:44 ` Tzung-Bi Shih @ 2022-11-18 8:59 ` Lee Jones 2022-11-18 9:19 ` Tzung-Bi Shih 0 siblings, 1 reply; 8+ messages in thread From: Lee Jones @ 2022-11-18 8:59 UTC (permalink / raw) To: Tzung-Bi Shih Cc: Mark Hasemeyer, LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Rob Herring, chrome-platform, devicetree On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: > On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > > Add DT compatible string in > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > The patch doesn't apply. Please rebase it. Were you actually trying to apply the patch, or just testing? -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-18 8:59 ` Lee Jones @ 2022-11-18 9:19 ` Tzung-Bi Shih 2022-11-18 12:47 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Tzung-Bi Shih @ 2022-11-18 9:19 UTC (permalink / raw) To: Lee Jones Cc: Mark Hasemeyer, LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Rob Herring, chrome-platform, devicetree On Fri, Nov 18, 2022 at 08:59:13AM +0000, Lee Jones wrote: > On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: > > > On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: > > > Add DT compatible string in > > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > > > The patch doesn't apply. Please rebase it. > > Were you actually trying to apply the patch, or just testing? Was trying to apply the patch to my local Linux tree (for-next) for reading the series. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-18 9:19 ` Tzung-Bi Shih @ 2022-11-18 12:47 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-11-18 12:47 UTC (permalink / raw) To: Tzung-Bi Shih, Lee Jones Cc: Mark Hasemeyer, LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Rob Herring, chrome-platform, devicetree On 18/11/2022 10:19, Tzung-Bi Shih wrote: > On Fri, Nov 18, 2022 at 08:59:13AM +0000, Lee Jones wrote: >> On Fri, 18 Nov 2022, Tzung-Bi Shih wrote: >> >>> On Thu, Nov 17, 2022 at 11:48:47AM -0700, Mark Hasemeyer wrote: >>>> Add DT compatible string in >>>> Documentation/devicetree/bindings/mfd/cros_ec.txt >>> >>> The patch doesn't apply. Please rebase it. >> >> Were you actually trying to apply the patch, or just testing? > > Was trying to apply the patch to my local Linux tree (for-next) for > reading the series. Are you sure then you choose correct base? Because with instructions "please rebase" you actually could encourage to rebase it on incorrect base... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-17 18:48 ` [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Mark Hasemeyer 2022-11-18 5:44 ` Tzung-Bi Shih @ 2022-11-18 12:42 ` Guenter Roeck 2022-11-18 14:28 ` Lee Jones 2022-11-18 12:49 ` Krzysztof Kozlowski 2 siblings, 1 reply; 8+ messages in thread From: Guenter Roeck @ 2022-11-18 12:42 UTC (permalink / raw) To: Mark Hasemeyer Cc: LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Lee Jones, Rob Herring, chrome-platform, devicetree On Thu, Nov 17, 2022 at 10:49 AM Mark Hasemeyer <markhas@chromium.org> wrote: > > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt > This is now google,cros-ec.yaml Guenter > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> > --- > > Changes in v7: > - No change > > Changes in v6: > - No change > > Changes in v5: > - No change > > Changes in v4: > - Changes in commit message. > > Changes in v3: > - Rebased changes on google,cros-ec.yaml > > Changes in v2: > - No change > > --- > .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > index 04962bb29576e..26787e4574b8d 100644 > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -28,6 +28,9 @@ properties: > - description: > For implementations of the EC is connected through RPMSG. > const: google,cros-ec-rpmsg > + - description: > + For implementations of the EC is connected through UART. > + const: google,cros-ec-uart > > controller-data: > description: > @@ -222,4 +225,12 @@ examples: > compatible = "google,cros-ec-rpmsg"; > }; > }; > + > + # Example for UART > + - | > + uart0 { > + cros-ec { > + compatible = "google,cros-ec-uart"; > + }; > + }; > ... > -- > 2.38.1.584.g0f3c55d4c2-goog > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-18 12:42 ` Guenter Roeck @ 2022-11-18 14:28 ` Lee Jones 0 siblings, 0 replies; 8+ messages in thread From: Lee Jones @ 2022-11-18 14:28 UTC (permalink / raw) To: Guenter Roeck Cc: Mark Hasemeyer, LKML, Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Rob Herring, chrome-platform, devicetree On Fri, 18 Nov 2022, Guenter Roeck wrote: > On Thu, Nov 17, 2022 at 10:49 AM Mark Hasemeyer <markhas@chromium.org> wrote: > > > > Add DT compatible string in > > Documentation/devicetree/bindings/mfd/cros_ec.txt > > > > This is now google,cros-ec.yaml Also there is no need to repeat the filename in the commit message. We can see that in the diff-stat below. Please come up with a more imaginative commit message. Exactly what are you doing, why you're doing it will do. > > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org> > > Signed-off-by: Mark Hasemeyer <markhas@chromium.org> > > --- > > > > Changes in v7: > > - No change > > > > Changes in v6: > > - No change > > > > Changes in v5: > > - No change > > > > Changes in v4: > > - Changes in commit message. > > > > Changes in v3: > > - Rebased changes on google,cros-ec.yaml > > > > Changes in v2: > > - No change > > > > --- > > .../devicetree/bindings/mfd/google,cros-ec.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index 04962bb29576e..26787e4574b8d 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -28,6 +28,9 @@ properties: > > - description: > > For implementations of the EC is connected through RPMSG. > > const: google,cros-ec-rpmsg > > + - description: > > + For implementations of the EC is connected through UART. > > + const: google,cros-ec-uart > > > > controller-data: > > description: > > @@ -222,4 +225,12 @@ examples: > > compatible = "google,cros-ec-rpmsg"; > > }; > > }; > > + > > + # Example for UART > > + - | > > + uart0 { > > + cros-ec { > > + compatible = "google,cros-ec-uart"; > > + }; > > + }; > > ... > > -- Lee Jones [李琼斯] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" 2022-11-17 18:48 ` [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Mark Hasemeyer 2022-11-18 5:44 ` Tzung-Bi Shih 2022-11-18 12:42 ` Guenter Roeck @ 2022-11-18 12:49 ` Krzysztof Kozlowski 2 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2022-11-18 12:49 UTC (permalink / raw) To: Mark Hasemeyer, LKML Cc: Raul Rangel, Bhanu Prakash Maiya, Benson Leung, Guenter Roeck, Krzysztof Kozlowski, Lee Jones, Rob Herring, chrome-platform, devicetree On 17/11/2022 19:48, Mark Hasemeyer wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt As pointed this is not valid path anymore. Subject: Drop second, redundant "DT" word. With both fixed: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-18 14:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221117114818.v7.1.If7926fcbad397bc6990dd725690229bed403948c@changeid>
2022-11-17 18:48 ` [PATCH v7 2/3] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Mark Hasemeyer
2022-11-18 5:44 ` Tzung-Bi Shih
2022-11-18 8:59 ` Lee Jones
2022-11-18 9:19 ` Tzung-Bi Shih
2022-11-18 12:47 ` Krzysztof Kozlowski
2022-11-18 12:42 ` Guenter Roeck
2022-11-18 14:28 ` Lee Jones
2022-11-18 12:49 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).