From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4B1C433FE for ; Fri, 18 Nov 2022 14:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242350AbiKROcg (ORCPT ); Fri, 18 Nov 2022 09:32:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242390AbiKROca (ORCPT ); Fri, 18 Nov 2022 09:32:30 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 80F1C2338C; Fri, 18 Nov 2022 06:32:29 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 87C8B807E; Fri, 18 Nov 2022 14:22:22 +0000 (UTC) Date: Fri, 18 Nov 2022 16:32:27 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Nishanth Menon , Vignesh Raghavendra Subject: Re: [PATCH] dt-bindings: pwm: ti,pwm-omap-dmtimer: Update binding for yaml Message-ID: References: <20221118125435.9479-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Krzysztof Kozlowski [221118 14:12]: > On 18/11/2022 13:54, Tony Lindgren wrote: > > +properties: > > + $nodename: > > + pattern: "^pwm-([1-9]|1[0-2])$" > > Drop the nodename, device schemas do not need to enforce it. Hmm I think that's needed to avoid warnings if the knob is tweaked to 11? Right now the max timer value is 12. > > + ti,prescaler: > > + description: legacy clock prescaled for timer > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] > > + deprecated: true > > This was not deprecated before and your commit msg does not mention it. OK will add and fix up the other things you noticed too. Thanks, Tony