Re: [RFC PATCH 1/3] usb: Add USB repeater generic framework

[Abel Vesa <abel.vesa@linaro.org>]

On 22-11-18 09:59:43, Andrzej Pietrasiewicz wrote:
> Hi Abel,
> 
> W dniu 16.11.2022 o 13:30, Abel Vesa pisze:
> > With more SoCs moving towards eUSB2,
> 
> Can you name a few?

Right now, for SoCs, I can only name the SM8550 from Qualcomm. But I
would think there will be more from now on, not just from Qualcomm.

But I found a couple of more repeaters already existent. Like TUSB2E11
or TUSB2E22 from TI or PTN3222 from NXP. I'm not sure if they are used
already alongside any specific SoC though (yet).

Anyway, I can rephrase that.

> 
> such platforms will have to use
> > a USB 2.0 compliance repeater. This repeater HW-wise usually deals with
> > level shifting, but depending on the implementation it can do much more.
> > So add a ganeric USB framework that would allow either a generic PHY or
> > some USB host controller to control and get a repeater from a devicetree
> > phandle. This framework will further be used by platform specific
> > drivers to register the repeater and implement platform specific ops.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >   drivers/usb/Kconfig             |   2 +
> >   drivers/usb/Makefile            |   2 +
> >   drivers/usb/repeater/Kconfig    |   9 ++
> >   drivers/usb/repeater/Makefile   |   6 +
> >   drivers/usb/repeater/repeater.c | 198 ++++++++++++++++++++++++++++++++
> >   include/linux/usb/repeater.h    |  78 +++++++++++++
> >   6 files changed, 295 insertions(+)
> >   create mode 100644 drivers/usb/repeater/Kconfig
> >   create mode 100644 drivers/usb/repeater/Makefile
> >   create mode 100644 drivers/usb/repeater/repeater.c
> >   create mode 100644 include/linux/usb/repeater.h
> > 
> 
> <snip>
> 
> > diff --git a/include/linux/usb/repeater.h b/include/linux/usb/repeater.h
> > new file mode 100644
> > index 000000000000..e68e0936f1e5
> > --- /dev/null
> > +++ b/include/linux/usb/repeater.h
> > @@ -0,0 +1,78 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * USB Repeater defines
> > + */
> > +
> > +#ifndef __LINUX_USB_REPEATER_H
> > +#define __LINUX_USB_REPEATER_H
> > +
> > +struct usb_repeater {
> > +	struct device		*dev;
> > +	const char		*label;
> > +	unsigned int		 flags;
> > +
> > +	struct list_head	head;
> 
> This member serves the purpose of a list _entry_, no?
> The _head_ is static LIST_HEAD(usb_repeater_list);
> Maybe call it "entry"?

Sure thing. Will do.

> 
> > +	int	(*reset)(struct usb_repeater *rptr, bool assert);
> > +	int	(*init)(struct usb_repeater *rptr);
> > +	int	(*power_on)(struct usb_repeater *rptr);
> > +	int	(*power_off)(struct usb_repeater *rptr);
> 
> Would you document these ops somehow? Potential driver writers need to
> understand when they are called and what they are supposed to do.
> In particular, how do these relate to what's in "Embedded USB2 (eUSB2)
> Physical Layer Supplement to the USB Revision 2.0 Specification"?

Yes. Will document them appropriately.

> 
> Regards,
> 
> Andrzej

Thanks,
Abel