From: Matthias Kaehlcke <mka@chromium.org>
To: Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add a herobrine CRD Pro SKU
Date: Mon, 21 Nov 2022 16:39:27 +0000 [thread overview]
Message-ID: <Y3upv3kACHXycKGs@google.com> (raw)
In-Reply-To: <20221121043437.21925-2-quic_rjendra@quicinc.com>
On Mon, Nov 21, 2022 at 10:04:37AM +0530, Rajendra Nayak wrote:
> Some of the qualcomm qcard based herobrine devices can come with
> a Pro variant of the chipset on the qcard.
nit: remove line break, the next sentence clearly refers to the one
above
> Such Pro qcards have the smps9 from pm8350c ganged up with smps7 and
> smps8, so Add a .dtsi for pro skus that deletes the
nit: s/so Add/so add/
nit: use +/- consistent line length
> smps9 node and include it from the new dts for the CRD Pro
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2022-11-21 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 4:34 [PATCH v2 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Rajendra Nayak
2022-11-21 4:34 ` [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add a herobrine CRD Pro SKU Rajendra Nayak
2022-11-21 10:16 ` Krzysztof Kozlowski
2022-11-21 16:39 ` Matthias Kaehlcke [this message]
2022-11-21 10:15 ` [PATCH v2 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Krzysztof Kozlowski
2022-11-21 16:36 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3upv3kACHXycKGs@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).