From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4EAC4332F for ; Mon, 21 Nov 2022 16:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiKUQja (ORCPT ); Mon, 21 Nov 2022 11:39:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbiKUQj3 (ORCPT ); Mon, 21 Nov 2022 11:39:29 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 693A221AC for ; Mon, 21 Nov 2022 08:39:28 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id e189so9032683iof.1 for ; Mon, 21 Nov 2022 08:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dE7kPnKhfd0itHP4HNTeLNi8/xUnwT2X5NbZWt65LF4=; b=oX47rmq07gA887+bDxsM54hg5i1NxG6EIqIA004JJihcEzG4qBc43iXYpr9FFaBG52 MQy9c/35mqLGMjjnmfSsJrrdB/0eE1zLY7IFVhpaw5Fri37G4IrWCdkuzSFnwSiJ397N 7TO86OPaVLEuUrRBdb/7P/r2VdaSfFyVpR9QY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dE7kPnKhfd0itHP4HNTeLNi8/xUnwT2X5NbZWt65LF4=; b=gxQvhdJPXVtwNsqn/ib96S4SSznMkIh58QdnZ7n21nYg9ngTA+teRVJz0FceuFFclw m0kbZ4T2b7ZP7iczSdCeVU+EX4vKSNXwGxbD8a9bBpblNPW4X5V0rn7L5r2XeGAYYlnK trk2sZKPYJXbv578zTZZktBM1vXat6mYTKvEpz9ntH2bYJFGv+VDKzKWLmXqIJn4AkVh IDMJJloADmzDGtLykwCNHzzPZlWFPem/uyhczkBAfw0m7OY38w0bmntxEkST3RElqbFe rmmBYZoQgB0p6tGXkttTBARq2WyIL2GbHBV1bB37Fvhj3YqzPwzBtF8I52iyaZxwDVdx hoUQ== X-Gm-Message-State: ANoB5pmGurjiTqLHiCeUz16MX++rROUCXe25/cKF1AAT/bvwWKkAZW4t BS+sWkoA2mQuZ4O09dzU7apiug== X-Google-Smtp-Source: AA0mqf4WCRaZA4lkpa1AVLfaY5hgI2Vne9hf4BcOm+gLWUvcduxR8VjpHgp7Un6qQ8TxqGnWJ0PulQ== X-Received: by 2002:a02:9666:0:b0:363:b82d:d51e with SMTP id c93-20020a029666000000b00363b82dd51emr8928069jai.15.1669048767786; Mon, 21 Nov 2022 08:39:27 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id t20-20020a02b194000000b0036cc14af7adsm4430766jah.149.2022.11.21.08.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 08:39:27 -0800 (PST) Date: Mon, 21 Nov 2022 16:39:27 +0000 From: Matthias Kaehlcke To: Rajendra Nayak Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280: Add a herobrine CRD Pro SKU Message-ID: References: <20221121043437.21925-1-quic_rjendra@quicinc.com> <20221121043437.21925-2-quic_rjendra@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221121043437.21925-2-quic_rjendra@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Nov 21, 2022 at 10:04:37AM +0530, Rajendra Nayak wrote: > Some of the qualcomm qcard based herobrine devices can come with > a Pro variant of the chipset on the qcard. nit: remove line break, the next sentence clearly refers to the one above > Such Pro qcards have the smps9 from pm8350c ganged up with smps7 and > smps8, so Add a .dtsi for pro skus that deletes the nit: s/so Add/so add/ nit: use +/- consistent line length > smps9 node and include it from the new dts for the CRD Pro > > Signed-off-by: Rajendra Nayak Reviewed-by: Matthias Kaehlcke