From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1172AC433FE
	for <linux-devicetree@archiver.kernel.org>; Tue, 22 Nov 2022 04:44:01 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229585AbiKVEoA (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Mon, 21 Nov 2022 23:44:00 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56328 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229482AbiKVEn6 (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Mon, 21 Nov 2022 23:43:58 -0500
Received: from muru.com (muru.com [72.249.23.125])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 62BE026ACA;
        Mon, 21 Nov 2022 20:43:57 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
        by muru.com (Postfix) with ESMTPS id 0C07780A7;
        Tue, 22 Nov 2022 04:33:43 +0000 (UTC)
Date:   Tue, 22 Nov 2022 06:43:55 +0200
From:   Tony Lindgren <tony@atomide.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-omap@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        Nishanth Menon <nm@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: pwm: Allow decimal format in
 addition to hex format
Message-ID: <Y3xTi5JeLPSWchT7@atomide.com>
References: <20221121115525.36362-1-tony@atomide.com>
 <20221121144000.7weeyfbbulltfxmd@pengutronix.de>
 <Y3uPvYqaILNiYW8K@atomide.com>
 <bb5ac0cf-84eb-165f-40bb-0f3c9afe084f@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bb5ac0cf-84eb-165f-40bb-0f3c9afe084f@linaro.org>
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [221121 16:05]:
> On 21/11/2022 15:48, Tony Lindgren wrote:
> > * Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [221121 14:30]:
> >> On Mon, Nov 21, 2022 at 01:55:24PM +0200, Tony Lindgren wrote:
> >>> Let's allow node numbering in decimal format too.
> >>>
> >>> Simple human-readable increments/IDs are usually decimal, hex is only for
> >>> addresses as noted by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>.
> >>>
> >>> Cc: Thierry Reding <thierry.reding@gmail.com>
> >>> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
> >>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> >>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> >>> @@ -13,7 +13,7 @@ select: false
> >>>  
> >>>  properties:
> >>>    $nodename:
> >>> -    pattern: "^pwm(@.*|-[0-9a-f])*$"
> >>> +    pattern: "^pwm(@.*|-([0-9a-f]|1[0-5]))*$"
> >>
> >> I wonder why you don't make this:
> >>
> >> +    pattern: "^pwm(@.*|-[0-9a-f]*)$"
> 
> Yes, the '*' should be within ().

Sorry I guess I don't follow. So for what type of naming is the second '*'
actually needed here, or is it needed at all?

We only want to match the following:

pwm@1234

pwm-0
...
pwm-f

And now also:

pwm-0
...
pwm-15

Is there yet another format I'm missing?

> > Hmm but I think this would also pass for node names like pwm-a-foo?
> > 
> 
> No, how?

Because of the second extra '*' there :)

Regards,

Tony