From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D94C63705 for ; Tue, 6 Dec 2022 21:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229737AbiLFVmn (ORCPT ); Tue, 6 Dec 2022 16:42:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiLFVmg (ORCPT ); Tue, 6 Dec 2022 16:42:36 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB04C32 for ; Tue, 6 Dec 2022 13:42:33 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id l11so22335453edb.4 for ; Tue, 06 Dec 2022 13:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w6SKBfsG69v/G59R3JpQZMBAr09gp1lj2RaDqDluJ9o=; b=JyTN2+0YDPQGraLJ+F5D+m8j5jfPg/5DtRG6jPGwxOH/h98JaeKHfCjEGkq+e5qSSW yxCqrFO1msTKmVZL78/TPWTLnsFh7fN7E6HYQL0XfVyTX1XFOuVrVuEvuxBHtKTa1lj4 4Up/L8kThSSiUUQe3EwK9xXj7AmwUa50k6X54ISqiYj7dN0SoFEVQ/i38SAb+A8IHp07 egPuYEJ92qkRZyWisQUgP3SBKVWOZ9Vh+bdBbPIf+Bv1pyEMQs2naOGffqDQdff7OiZg +Km+hZX2Q5PSwPw1X+eHXh9Xm1NYVpqNTkV/XpNj72X/2Y0AZpi3Zdrpvc4sBrXLCu7R Ntzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w6SKBfsG69v/G59R3JpQZMBAr09gp1lj2RaDqDluJ9o=; b=LGpZ9/yc0Nd0TPmTeLrBC4jrNenS0VQTSIxYJf0W7fjXpN/mdlzx2d7qd4zuNwx9bB 7aFO7qDY48VGyCXkh9GVVt8P6PsWDDrcjLNCmj345/3edtQvv6YA1rTkwGprIVGlnA9G ZSea8hYraakkCrT6mSVMngtZ7M4NunEg1y26Zv/iUDhfcfIPPDLkRBwHJI4g+cSFdpOC 2SHrLlNStNXfU52pam6BKcxYfgNRttuBr/fGZoyOHuOJ7Mgi7akIw0w9txc7mz56+zxT 0sq0Ksq3LDvCyxnFODflHZvlU1Vk9UjPwvu3NYC6ARHYvODhPercSlYx/4M7edOAg9Dy CpuQ== X-Gm-Message-State: ANoB5pkTGyFwyHFpIdhzU3hkQHvMVw6K41RZElSUIwVdfVFEQ5Jyivlm VUwhqMNhaTdvP6848D0e/fzj5w== X-Google-Smtp-Source: AA0mqf5Ge71m/n5V0SR0lNuLf7XobkHDw98VWR3Sf/cV71e4GhWsAZSpCUcf+Tp4wkzIUcG2GUi+Mg== X-Received: by 2002:aa7:dd4b:0:b0:467:65a2:f635 with SMTP id o11-20020aa7dd4b000000b0046765a2f635mr66802120edw.106.1670362951972; Tue, 06 Dec 2022 13:42:31 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id kx4-20020a170907774400b0079e11b8e891sm7744392ejc.125.2022.12.06.13.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 13:42:31 -0800 (PST) Date: Tue, 6 Dec 2022 23:42:30 +0200 From: Abel Vesa To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v5 1/5] dt-bindings: clock: Add SM8550 TCSR CC clocks Message-ID: References: <20221206125635.952114-1-abel.vesa@linaro.org> <20221206125635.952114-2-abel.vesa@linaro.org> <20221206182332.oi7mxxryv2kvd3wu@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206182332.oi7mxxryv2kvd3wu@builder.lan> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22-12-06 12:23:32, Bjorn Andersson wrote: > On Tue, Dec 06, 2022 at 02:56:31PM +0200, Abel Vesa wrote: > > Add bindings documentation for clock TCSR driver on SM8550. > > > > Signed-off-by: Abel Vesa > > Reviewed-by: Krzysztof Kozlowski > > --- > > .../bindings/clock/qcom,sm8550-tcsr.yaml | 53 +++++++++++++++++++ > > include/dt-bindings/clock/qcom,sm8550-tcsr.h | 18 +++++++ > > 2 files changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml > > create mode 100644 include/dt-bindings/clock/qcom,sm8550-tcsr.h > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml > > new file mode 100644 > > index 000000000000..15176b0457d1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsr.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/qcom,sm8550-tcsr.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm TCSR Clock Controller on SM8550 > > + > > +maintainers: > > + - Bjorn Andersson > > + > > +description: | > > + Qualcomm TCSR clock control module provides the clocks, resets and > > + power domains on SM8550 > > + > > + See also:: include/dt-bindings/clock/qcom,sm8550-tcsr.h > > + > > +properties: > > + compatible: > > + const: qcom,sm8550-tcsr > > + > > + clocks: > > + items: > > + - description: Board XO source > > This sounds like the crystal feeding the PMIC, but the clock here should > be the signal that arrives at the CXO pin of the SoC. Oh, I guess this should be: - description: TCXO pad clock Will send a new version. > > Other than that, this looks good now. > > Thanks, > Bjorn > > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > +required: > > + - compatible > > + - clocks > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + clock-controller@1fc0000 { > > + compatible = "qcom,sm8550-tcsr"; > > + reg = <0x1fc0000 0x30000>; > > + clocks = <&rpmhcc RPMH_CXO_PAD_CLK>; > > + #clock-cells = <1>; > > + #reset-cells = <1>; > > + }; > > + > > +... > > diff --git a/include/dt-bindings/clock/qcom,sm8550-tcsr.h b/include/dt-bindings/clock/qcom,sm8550-tcsr.h > > new file mode 100644 > > index 000000000000..091cb76f953a > > --- /dev/null > > +++ b/include/dt-bindings/clock/qcom,sm8550-tcsr.h > > @@ -0,0 +1,18 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * Copyright (c) 2022, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2022, Linaro Limited > > + */ > > + > > +#ifndef _DT_BINDINGS_CLK_QCOM_TCSR_CC_SM8550_H > > +#define _DT_BINDINGS_CLK_QCOM_TCSR_CC_SM8550_H > > + > > +/* TCSR CC clocks */ > > +#define TCSR_PCIE_0_CLKREF_EN 0 > > +#define TCSR_PCIE_1_CLKREF_EN 1 > > +#define TCSR_UFS_CLKREF_EN 2 > > +#define TCSR_UFS_PAD_CLKREF_EN 3 > > +#define TCSR_USB2_CLKREF_EN 4 > > +#define TCSR_USB3_CLKREF_EN 5 > > + > > +#endif > > -- > > 2.34.1 > >