From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38D0C4321E for ; Mon, 5 Dec 2022 12:07:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbiLEMHR (ORCPT ); Mon, 5 Dec 2022 07:07:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231307AbiLEMHP (ORCPT ); Mon, 5 Dec 2022 07:07:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB13DF61; Mon, 5 Dec 2022 04:07:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8EDF9B80F93; Mon, 5 Dec 2022 12:07:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ACF3C433D6; Mon, 5 Dec 2022 12:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670242032; bh=nbVll1UJq4AQLhzCQgmeFzFvQNQuvneOX3xjaOlj+e4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qB1J99DF86iViwbgNldFH4Gk2vUeZgtbilZV60VobZ4r2E6G2q0qT0HAMPqlVzGk5 aPd3KbrscO7WvRR8k7L1zWiPNrTGSUR6YFdTO3iaywrboXXhhG88Qxwjeo64U0HscN pR90gest5KlzP1j6JC1y7hFsraVqD3BOEHdiQkXhr5tweicnauFJyka008tOI3XMfX 67nGSMCYeBcD3yF1ghMVWmR0Abq0hjDOUYDMrgFQwEV6NreJClpAE1w7mFWsuKrFSl 0lOEc8Xkc99Mf+vi4+4s/WoryU9CCvKAtBbdJqblz96pG4A1TOlzMR8KlE99Ae9O1m DQPjmqCM5Du5w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p2AFg-0008W9-OO; Mon, 05 Dec 2022 13:07:17 +0100 Date: Mon, 5 Dec 2022 13:07:16 +0100 From: Johan Hovold To: Manivannan Sadhasivam Cc: Johan Hovold , Bjorn Andersson , Alim Akhtar , Avri Altman , Andy Gross , Konrad Dybcio , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: allow 'dma-coherent' property Message-ID: References: <20221205100837.29212-1-johan+linaro@kernel.org> <20221205100837.29212-2-johan+linaro@kernel.org> <20221205115906.GA20192@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205115906.GA20192@thinkpad> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 05, 2022 at 05:29:06PM +0530, Manivannan Sadhasivam wrote: > On Mon, Dec 05, 2022 at 11:08:36AM +0100, Johan Hovold wrote: > > UFS controllers may be cache coherent and must be marked as such in the > > devicetree to avoid data corruption. > > > > This is specifically needed on recent Qualcomm platforms like SC8280XP. > > > > Signed-off-by: Johan Hovold > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index f2d6298d926c..1f1d286749c0 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -44,6 +44,8 @@ properties: > > minItems: 8 > > maxItems: 11 > > > > + dma-coherent: true > > + > > This property is not applicable to all SoCs. So setting true here will make it > valid for all. Yes, it would be a valid, but it will only be added to the DTs of SoCs that actually require it. No need to re-encode the dtsi in the binding. Johan