From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Juxin Gao <gaojuxin@loongson.cn>, Bibo Mao <maobibo@loongson.cn>,
Yanteng Si <siyanteng@loongson.cn>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, Arnaud Patard <apatard@mandriva.com>,
Huacai Chen <chenhuacai@kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
Hongchen Zhang <zhanghongchen@loongson.cn>,
Liu Peibao <liupeibao@loongson.cn>
Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support
Date: Mon, 5 Dec 2022 14:53:09 +0200 [thread overview]
Message-ID: <Y43ptYqOznh+jhFG@smile.fi.intel.com> (raw)
In-Reply-To: <899d9d4c-36e8-6a4f-4243-dcf16f9ef29f@loongson.cn>
On Mon, Dec 05, 2022 at 02:04:09PM +0800, Yinbo Zhu wrote:
> 在 2022/12/3 23:41, Andy Shevchenko 写道:
...
> I just compile it that it is still okay when remove acpi.h, so I will remove
> it in v11.
You need to address all review comments. I don't remember if I reviewed this,
but there are a lot of contribution from your side to the different subsystems
where I have commented on your code and you can check those reviews because
some of the remarks can be applied to this contribution as well.
Nevertheless, please Cc me in your v11 when you consider it will be ready.
Note, you have approx. month now to make it better. Of course you can
send a version to review before that.
...
> and, I'm afraid I didn't catch your meaning about "
>
> what that "nice" container of the platform device for."
>
> you said is for following code ?
> 144 struct platform_device *pdev =
> 145 container_of(chip->parent, struct platform_device, dev);
Have you seen to_platform_device() macro?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-12-05 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 12:32 [PATCH v10 1/2] gpio: loongson: add gpio driver support Yinbo Zhu
2022-12-01 12:32 ` [PATCH v10 2/2] dt-bindings: gpio: add loongson gpio Yinbo Zhu
2022-12-02 16:11 ` [PATCH v10 1/2] gpio: loongson: add gpio driver support Bartosz Golaszewski
2022-12-03 10:03 ` Linus Walleij
2022-12-03 10:53 ` Yinbo Zhu
2022-12-03 15:27 ` Andy Shevchenko
2022-12-03 15:41 ` Andy Shevchenko
2022-12-03 17:45 ` Bartosz Golaszewski
2022-12-05 6:04 ` Yinbo Zhu
2022-12-05 12:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y43ptYqOznh+jhFG@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=apatard@mandriva.com \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gaojuxin@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=siyanteng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).