From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0898C47089 for ; Mon, 5 Dec 2022 13:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbiLENQ3 (ORCPT ); Mon, 5 Dec 2022 08:16:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbiLENQ0 (ORCPT ); Mon, 5 Dec 2022 08:16:26 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9824C11C0A; Mon, 5 Dec 2022 05:16:25 -0800 (PST) Received: from zn.tnic (p200300ea9733e72f329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e72f:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 97C481EC0531; Mon, 5 Dec 2022 14:16:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1670246183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=LebK9vlxoxcDxyhwhYhootxASRZx+GLX1jsVAwpEJA0=; b=cwR7RWJXOTlMHRiqIiOkofWod1zLKpp2yvb22/rbqlSzCUZBZimjsdqGDrBt2LpjyO9tUZ d3V2YPZzwSIriARxl9aDB7BUXKi6P9t44BJQl7KgvnwpysEOsx2EpaIQFU9V/yo8MrorfS /b1jp8OZSqoI5lx+l5T9sjaVGmg/jdE= Date: Mon, 5 Dec 2022 14:16:20 +0100 From: Borislav Petkov To: "Potthuri, Sai Krishna" Cc: Rob Herring , Krzysztof Kozlowski , Michal Simek , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "saikrishna12468@gmail.com" , "git (AMD-Xilinx)" , "Datta, Shubhrajyoti" , kernel test robot Subject: Re: [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP OCM Message-ID: References: <20221102070655.247511-1-sai.krishna.potthuri@amd.com> <20221102070655.247511-3-sai.krishna.potthuri@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 05, 2022 at 10:20:11AM +0000, Potthuri, Sai Krishna wrote: > As we communicated earlier for ZynqMP platform we have both Synopsys > (for DDRMC) and zynqmp_ocm_edac (for OCM) drivers. Just to be clear > about what this driver is targeted for, we used ocm as part of file > name. Ok, zynqmp_edac.c looks fine, will update. Yeah, we can always rename later, when another driver is needed. For now, let's keep things simple. > Ok, will update API documentation like below. > echo > /sys/kernel/debug/edac/ff960000.memory-controller/inject_fault_count ^^^^^^^^^^^^^^^^^^^^^^^^^^ Any particular reason this should not be called simply "mc0" or so? At least this is how we call them on x86... > echo > /sys/kernel/debug/edac/ff960000.memory-controller/inject_ue_bitpos echo , > ... I guess. The ',' or ':' or some other separator which is not blank space would make it more obvious that the two bits belong together and you won't have to scan further for the second value but simply have a single string which you split at the separator. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette