From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08C5C43217 for ; Mon, 28 Nov 2022 10:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbiK1KOc (ORCPT ); Mon, 28 Nov 2022 05:14:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiK1KOc (ORCPT ); Mon, 28 Nov 2022 05:14:32 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 693D013E35; Mon, 28 Nov 2022 02:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669630471; x=1701166471; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=x0vkDNxcTGDBQx1tdJF7VOl/Y7E12BTrTMtu7ZOaq8Y=; b=FiLEkTPsu5Gt8yKtJGSkVj2+Fb3GuJrmkwSpbyW2V4yr4lsTTrqhI8/f +RUfpb6h6m4zM52mRIa1WBduu1XJoQHWzhstFLiAo3M38SYmJE9M6k8kB pf+JTo3QgfIOsVKGVHkzGFKZPRLPLCjf2ou3dJb1x5A/rel+Qq8uRD7t0 N9JESRUyPWF5HKBDIOo8wTRl1DncsrYWeob8TAEgJKx+8TFL/7OOcVQSo uBYPBoqnZr6kNSMTZRgatvtlUGRnl40lwuAhsaeoSf8nAhlFBSOm0BLrO iPJxui2HZ67Y3n/NO1PkkxUrTDkGTtVPJoK7kiK+5+3Zr25CRvhrLj0Ul g==; X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="341710981" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="341710981" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 02:14:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10544"; a="637168198" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="637168198" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 28 Nov 2022 02:14:27 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ozb9d-0014Vw-37; Mon, 28 Nov 2022 12:14:25 +0200 Date: Mon, 28 Nov 2022 12:14:25 +0200 From: Andy Shevchenko To: Christophe JAILLET Cc: Rob Herring , Frank Rowand , Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] gpio: Do not include when not really needed. Message-ID: References: <3f75784c57dc0682b5e1758daddd93fee6bb4b27.1669585920.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f75784c57dc0682b5e1758daddd93fee6bb4b27.1669585920.git.christophe.jaillet@wanadoo.fr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Nov 27, 2022 at 10:52:10PM +0100, Christophe JAILLET wrote: > is included only for using container_of(). > Include instead, it is much lighter. Reviewed-by: Andy Shevchenko Thanks for doing this! We really don't want to see kernel.h to be included by other headers in the include/linux, include/asm, etc. > Signed-off-by: Christophe JAILLET > --- > Not sure if the prefix should be gpio or gpiolib. I'm not sure either because this more for the consumers, I would leave gpio. > Let see if build-bots spot something which is inherit via kernel.h > --- > include/linux/of_gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h > index a5166eb93437..6db627257a7b 100644 > --- a/include/linux/of_gpio.h > +++ b/include/linux/of_gpio.h > @@ -34,7 +34,7 @@ enum of_gpio_flags { > > #ifdef CONFIG_OF_GPIO > > -#include > +#include > > /* > * OF GPIO chip for memory mapped banks > -- > 2.34.1 > > -- With Best Regards, Andy Shevchenko