From: Andrew Lunn <andrew@lunn.ch>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Chukun Pan <amadeus@jmu.edu.cn>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Wu <david.wu@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ethernet: stmicro: stmmac: Add SGMII/QSGMII support for RK3568
Date: Tue, 29 Nov 2022 19:31:23 +0100 [thread overview]
Message-ID: <Y4ZP+0koq0xIm4H9@lunn.ch> (raw)
In-Reply-To: <e4676089-7ce2-e123-4e2a-a7d8835e9118@linaro.org>
> > -static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> > +static int rk_gmac_phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
> > {
> > struct regulator *ldo = bsp_priv->regulator;
> > int ret;
> > @@ -1728,6 +1909,18 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
> > "rockchip,grf");
> > bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> > "rockchip,php-grf");
> > + bsp_priv->xpcs = syscon_regmap_lookup_by_phandle(dev->of_node,
> > + "rockchip,xpcs");
> > + if (!IS_ERR(bsp_priv->xpcs)) {
> > + struct phy *comphy;
> > +
> > + comphy = devm_of_phy_get(&pdev->dev, dev->of_node, NULL);
>
> So instead of having PHY driver, you added a syscon and implemented PHY
> driver here. No. Make a proper PHY driver.
I'm also thinking there should be a proper pcs driver in drivers/net/pcs.
Andrew
next prev parent reply other threads:[~2022-11-29 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 7:27 [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rk3568 xpcs compatible Chukun Pan
2022-11-29 7:27 ` [PATCH 2/2] ethernet: stmicro: stmmac: Add SGMII/QSGMII support for RK3568 Chukun Pan
2022-11-29 8:53 ` Krzysztof Kozlowski
2022-11-29 18:31 ` Andrew Lunn [this message]
2022-11-29 8:49 ` [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rk3568 xpcs compatible Krzysztof Kozlowski
2022-11-29 8:51 ` Krzysztof Kozlowski
2022-11-29 9:56 ` Heiko Stübner
2022-11-29 9:59 ` Krzysztof Kozlowski
2022-11-29 10:22 ` Heiko Stübner
2022-12-01 23:22 ` Rob Herring
2022-12-03 9:00 ` Chukun Pan
2022-12-03 17:27 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4ZP+0koq0xIm4H9@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=amadeus@jmu.edu.cn \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).