From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD3BC47089 for ; Wed, 30 Nov 2022 20:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230205AbiK3Udo (ORCPT ); Wed, 30 Nov 2022 15:33:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiK3Ud2 (ORCPT ); Wed, 30 Nov 2022 15:33:28 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83943920AC; Wed, 30 Nov 2022 12:32:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669840342; x=1701376342; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tUXXdUxbyL1XhGdlXtjhkDQSLX/WQBuwUckCuNgvEI8=; b=EuOdY6zjyKs9uCMvc73Cs59gAdj1fNJvvqyt0JtRHZOVk7d2eTdphNMi 6zq8H1GmuSfU7ZDCdpxLxA5uJWfiwLWX5iUA0ZqiiSrVlO/OcjluXPowI +zd2FgmnyGXlZXos5+8jbid1e7zuk5NuTQRWyvfe3hNWGxeabF/44wBp4 ig/etHqH6ggxv5WcX/TjLnPXDvw9wFRikmByCdxc9vEXFbf4SZuS4CKiw areyI3/+rNssalR3uizp2EEnjzWmvERl2Y7IQv29FHwE2pi6+XexvKJzT 8OWLAGODHN7pcNp5jkt7m8sgnTFlB2+anpiQyWxbZE6sOC/FEhc87n8km A==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="313135098" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="313135098" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 12:32:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="786612376" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="786612376" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2022 12:32:15 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p0Tkb-002Szl-0T; Wed, 30 Nov 2022 22:32:13 +0200 Date: Wed, 30 Nov 2022 22:32:12 +0200 From: Andy Shevchenko To: Binbin Zhou Cc: Wolfram Sang , Wolfram Sang , Mika Westerberg , linux-i2c@vger.kernel.org, loongarch@lists.linux.dev, devicetree@vger.kernel.org, Huacai Chen , WANG Xuerui , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Jianmin Lv Subject: Re: [PATCH V4 2/5] i2c: gpio: Add support on ACPI-based system Message-ID: References: <05a28866877347f2aaed34288ad76963905e2f33.1669777792.git.zhoubinbin@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05a28866877347f2aaed34288ad76963905e2f33.1669777792.git.zhoubinbin@loongson.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 30, 2022 at 01:55:52PM +0800, Binbin Zhou wrote: > Add support for the ACPI-based device registration, so that the driver > can be also enabled through ACPI table. ... The of.h is left with this patch. Is it still needed? ... > +/* Get i2c-gpio props from DT or ACPI table */ properties > +static void i2c_gpio_get_props(struct device *dev, _properties > + struct i2c_gpio_platform_data *pdata) -- With Best Regards, Andy Shevchenko