From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F143DC4332F for ; Thu, 1 Dec 2022 22:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbiLAWgH (ORCPT ); Thu, 1 Dec 2022 17:36:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbiLAWgH (ORCPT ); Thu, 1 Dec 2022 17:36:07 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A912462EAB for ; Thu, 1 Dec 2022 14:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669934108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NDjeEfQppabaCfN3PfZotiNpYUYQN1CVDNNLoD78gq8=; b=TPKifk0wcUkuajrgbGxhbyEIYfpwzek33Q4L2LVEijZcoIaznTuwQa1gXl2KJX8g98Nnx7 iSVfaQ865Go3sH5pEDU9UbCjqC77sSTJNTWqBso44hWfBwEF0Wpxwu7p/9Huc/2dCgiQUc k0B5eQlZNn1aEYKupfY/pTtCjWGUFmo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-184-DY7PjA9hN4ejVly8WHYGng-1; Thu, 01 Dec 2022 17:35:07 -0500 X-MC-Unique: DY7PjA9hN4ejVly8WHYGng-1 Received: by mail-qv1-f71.google.com with SMTP id 71-20020a0c804d000000b004b2fb260447so9338626qva.10 for ; Thu, 01 Dec 2022 14:35:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NDjeEfQppabaCfN3PfZotiNpYUYQN1CVDNNLoD78gq8=; b=hBqjW8fHqvjMXHSFJdEEixmmrOibJ0ibd4iTYFUOyThDQVoh6pYiOKDpETviIUP/tj eCX2VtTvzIZcx9gGcYyJKtuI9BlnEY3o8r8Rq3DSe8Tqn8fZxpRgc9xAjNAhOqgXEuwc 2nZoxusQR90Ty8N5QTrhomk1oY+KAFw7hAqipQN5NI1TVZ8w4Z6d16SNwZlGwdrhcGpV E3F+z1gEtRsBjJndPSDLjpA7oOMgOAgbm2mrvDREARFGUYLYM55f8cbCwY6jiKwCM9Qp JWzNe7Ww5+8+Rl4oac6Uu6mtKjXnf4FtuGy68JjKpCkZWsTfyvVzQhtR5PgiYEREng/f 1zMg== X-Gm-Message-State: ANoB5plmeHKjsCjI1CGUyfZuw6sXmkhg5/ib4iza/eoPTRrBMD9VvAgq MuCxw6OBpmY32Fgt7GFbUpStbdzOi0jjvIOd2ANyedu2GiwR438+mjIVukdnaufXRB/uLpXW67J 1CvlNO6O1kTb/EjPtqIGSwg== X-Received: by 2002:ac8:6e8c:0:b0:3a6:996f:6b9d with SMTP id c12-20020ac86e8c000000b003a6996f6b9dmr126464qtv.42.1669934107403; Thu, 01 Dec 2022 14:35:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf6hTTagE5fWY7R0yg+9BDwvx6R5UWlRr2HG/dP1kllTRaddz/3iuPVVszoraFTXQ2H1LgZBKg== X-Received: by 2002:ac8:6e8c:0:b0:3a6:996f:6b9d with SMTP id c12-20020ac86e8c000000b003a6996f6b9dmr126447qtv.42.1669934107148; Thu, 01 Dec 2022 14:35:07 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id y17-20020a05620a25d100b006e54251993esm4291891qko.97.2022.12.01.14.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 14:35:06 -0800 (PST) Date: Thu, 1 Dec 2022 17:35:05 -0500 From: Brian Masney To: Bjorn Andersson Cc: krzysztof.kozlowski+dt@linaro.org, agross@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_shazhuss@quicinc.com, psodagud@quicinc.com, ahalaney@redhat.com, echanude@redhat.com Subject: Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support Message-ID: References: <20221201171931.1919961-1-bmasney@redhat.com> <20221201223012.r6mvz4updf3qoilj@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221201223012.r6mvz4updf3qoilj@builder.lan> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 01, 2022 at 04:30:12PM -0600, Bjorn Andersson wrote: > On Thu, Dec 01, 2022 at 12:19:31PM -0500, Brian Masney wrote: > > + vreg_l11a: ldo11 { > > + regulator-name = "vreg_l11a"; > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = ; > > + regulator-allow-set-load; > > In order to specify regulator-allow-set-load you also need > regulator-allowed-modes. > > But if I read the implementation correction, we don't actually alter the > load, so perhaps best to just omit this for now? I can drop regulator-allow-set-load in v3. I almost left it off and verified the other day that PCIe still works without it. Brian