From: Andrew Lunn <andrew@lunn.ch>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes
Date: Fri, 2 Dec 2022 18:30:52 +0100 [thread overview]
Message-ID: <Y4o2TFGH6DK3tRcH@lunn.ch> (raw)
In-Reply-To: <CAJ+vNU0kAoVFFmoFfiOhtErxqAkB3MmP3Q2dNCZP4xm_AaWhcA@mail.gmail.com>
> > > > port@5 {
> > > > reg = <5>;
> > > > label = "cpu";
> > > > ethernet = <&fec>;
> > > > + phy-mode = "rgmii-id";
> > > > +
> > > > + fixed-link {
> > > > + speed = <1000>;
> > > > + full-duplex;
> > > > + };
> > > > };
> >
> > This part is needed to make a warning go away. Does the SoC network interface
> > have phy-mode = "rgmii"; ?
>
> No, it looks like this:
>
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_enet>;
> phy-mode = "rgmii-id";
> Is something here wrong?
It suggests both ends should insert RGMII delays. So you will end up
with double delays. Have one end say plain "rgmii" and the other
"rgmii-id". I would probably go with the FEC being "rgmii".
Andrew
next prev parent reply other threads:[~2022-12-02 17:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 0:31 [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes Tim Harvey
2022-12-01 0:31 ` [PATCH 2/2] ARM: dts: imx6qdl-gw5904: add dt props for populating eth MAC addrs Tim Harvey
2022-12-02 1:02 ` Fabio Estevam
2022-12-02 1:02 ` [PATCH 1/2] ARM: dts: imx6qdl-gw5904: add internal mdio nodes Fabio Estevam
2022-12-02 13:08 ` Andrew Lunn
2022-12-02 16:48 ` Tim Harvey
2022-12-02 17:30 ` Andrew Lunn [this message]
2022-12-02 22:29 ` Tim Harvey
2022-12-04 0:15 ` Andrew Lunn
2022-12-05 17:10 ` Vladimir Oltean
2022-12-05 18:01 ` Tim Harvey
2022-12-05 19:02 ` Vladimir Oltean
2022-12-05 19:10 ` Tim Harvey
2022-12-05 19:15 ` Vladimir Oltean
2022-12-05 19:24 ` Tim Harvey
2022-12-05 19:37 ` Vladimir Oltean
2022-12-05 17:27 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4o2TFGH6DK3tRcH@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).