From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB484C4321E for ; Fri, 2 Dec 2022 19:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234369AbiLBTTM (ORCPT ); Fri, 2 Dec 2022 14:19:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234415AbiLBTTL (ORCPT ); Fri, 2 Dec 2022 14:19:11 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10A704387C for ; Fri, 2 Dec 2022 11:19:08 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id n21so13699786ejb.9 for ; Fri, 02 Dec 2022 11:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J943yYpuo0jFR9PCG/F9JS9VvWtOyHZ6S8cQEy5PX9s=; b=zIMn7QfCJdbk4wTH0N8lemUAvDDcSZo/Z+gBiKFz8ilbUjpEIe4S3P4uvqDDd+H+AM 5gg1OTe8VLzeMxXf7HC69s4F9H4ZSyW3R7jEzr7aF4yQKHXHdU/lehSD3gNzfp8rU39A Vqlg2vFP9WXVXctmx3ERTPpjFSf6OMwn9RV+Byk6C16lfFBg4FaDKOD2udXMBBbmBXJI arkM87qCeV3zTeBHIWUXH3wxhO/NL6FUao54jNTnlB1v7krtXvEviNPYKYZsHJCMN2Vg Nbbz0g91IPi1Nm65INfGgyfvaED0KbuKOFkLLGhK7D6/JP/XyNkf4FJH/R/pV+p/7vGx 1Nxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J943yYpuo0jFR9PCG/F9JS9VvWtOyHZ6S8cQEy5PX9s=; b=EjliwoRXcSl18fvMPxhxPwwLGiIAQe0dDtaKbm8cZzqLUBXMdTK4JdljpShFhwBTxv F3li0QoC0mGuae/yxQsFc8MKnjQN6XWJBFOAmZXG+UlWA+piZzpOZ/Dh1O67RdcBzXCv kE7nXUC1pAhl0UK1dU6qv+T9bpHe5GEz8g3wyw2BFYqTRYFbLp1LXsxC+Cp7hvP4fXPP qeZnr73Ssxm8jc1/Hhjv1xnoRFXyYSdIy6+MqrwPlaUvQ+IQhueVJUq8dPyNKn3FFqII ngHu6y69sBbCN1GI36ouhZxx9ssfnzyqyPXT6uLNFzgXqOTnIqpWASZsY0kuOk41L3Iy DZXg== X-Gm-Message-State: ANoB5pnrU/NPLHxT1P5nEfC6zlbiIOqGJSrnY61as18xsXk+Ar61i5Ka 0h6+Cbit6E8XSrXGX1FWxCr6rA== X-Google-Smtp-Source: AA0mqf7ogr9/tON+JEkHrEd1+Lltn3rha/i65c/OtJZfitNnrjQd44HPiL5kZj9Rj48yTucY21oj+w== X-Received: by 2002:a17:906:94c8:b0:7c0:a321:8df2 with SMTP id d8-20020a17090694c800b007c0a3218df2mr10838829ejy.308.1670008746540; Fri, 02 Dec 2022 11:19:06 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id d13-20020a17090694cd00b007c0b28b85c5sm2145585ejy.138.2022.12.02.11.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 11:19:05 -0800 (PST) Date: Fri, 2 Dec 2022 21:19:04 +0200 From: Abel Vesa To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Mike Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v4 2/9] dt-bindings: clock: Add SM8550 TCSR CC clocks Message-ID: References: <20221130112852.2977816-1-abel.vesa@linaro.org> <20221130112852.2977816-3-abel.vesa@linaro.org> <20221201221220.7kdbndug3m3om62p@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221201221220.7kdbndug3m3om62p@builder.lan> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22-12-01 16:12:20, Bjorn Andersson wrote: > On Wed, Nov 30, 2022 at 01:28:45PM +0200, Abel Vesa wrote: > > Add bindings documentation for clock TCSR driver on SM8550. > > > > Signed-off-by: Abel Vesa > > Reviewed-by: Krzysztof Kozlowski > > --- > > .../bindings/clock/qcom,sm8550-tcsrcc.yaml | 45 +++++++++++++++++++ > > .../dt-bindings/clock/qcom,sm8550-tcsrcc.h | 18 ++++++++ > > 2 files changed, 63 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml > > create mode 100644 include/dt-bindings/clock/qcom,sm8550-tcsrcc.h > > > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml > > new file mode 100644 > > index 000000000000..b2de251328e4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-tcsrcc.yaml > > @@ -0,0 +1,45 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/qcom,sm8550-tcsrcc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm TCSR Clock Controller on SM8550 > > + > > +maintainers: > > + - Bjorn Andersson > > + > > +description: | > > + Qualcomm TCSR clock control module provides the clocks, resets and > > + power domains on SM8550 > > + > > + See also:: include/dt-bindings/clock/qcom,sm8550-tcsrcc.h > > + > > +properties: > > + compatible: > > + const: qcom,sm8550-tcsrcc > > The block described is the TCSR block, the clock controller represents > one of the functions provided. I think it would be more appropriate if > the compatible represented the generic nature of the block, even though > you currently only care about exposing these clocks. I think there is a rule that says the compatible string to be the same as the schema filename. Should I then also rename the schema file and also the binding IDs header? Like qcom,sm8550-tcsr.yaml and qcom,sm8550-tcsr.h ? > > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + > > + '#reset-cells': > > + const: 1 > > + > > Your clocks are fed by cxo. While there might be reasons for not wire > the parent up in the clocks, I think you should represent it in the > binding. Right, will document the clocks property as well and describe the clock as xo-board. > > Regards, > Bjorn > > > +required: > > + - compatible > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + clock-controller@1fc0000 { > > + compatible = "qcom,sm8550-tcsrcc"; > > + reg = <0x1fc0000 0x30000>; > > + #clock-cells = <1>; > > + #reset-cells = <1>; > > + }; > > + > > +... > > diff --git a/include/dt-bindings/clock/qcom,sm8550-tcsrcc.h b/include/dt-bindings/clock/qcom,sm8550-tcsrcc.h > > new file mode 100644 > > index 000000000000..091cb76f953a > > --- /dev/null > > +++ b/include/dt-bindings/clock/qcom,sm8550-tcsrcc.h > > @@ -0,0 +1,18 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * Copyright (c) 2022, The Linux Foundation. All rights reserved. > > + * Copyright (c) 2022, Linaro Limited > > + */ > > + > > +#ifndef _DT_BINDINGS_CLK_QCOM_TCSR_CC_SM8550_H > > +#define _DT_BINDINGS_CLK_QCOM_TCSR_CC_SM8550_H > > + > > +/* TCSR CC clocks */ > > +#define TCSR_PCIE_0_CLKREF_EN 0 > > +#define TCSR_PCIE_1_CLKREF_EN 1 > > +#define TCSR_UFS_CLKREF_EN 2 > > +#define TCSR_UFS_PAD_CLKREF_EN 3 > > +#define TCSR_USB2_CLKREF_EN 4 > > +#define TCSR_USB3_CLKREF_EN 5 > > + > > +#endif > > -- > > 2.34.1 > >