From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A79BC4708E for ; Wed, 7 Dec 2022 11:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230077AbiLGLa2 (ORCPT ); Wed, 7 Dec 2022 06:30:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbiLGLaZ (ORCPT ); Wed, 7 Dec 2022 06:30:25 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E221748401; Wed, 7 Dec 2022 03:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670412624; x=1701948624; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kh4y6l6w9SxnJx5xFBJLdTUfM4uJK7lKR1XZ4zn7eHc=; b=gR+j7MNPRcvLGUula5OrV8AG48OpuYijt2nQcMbdILnUdzBXq/H/EI2x FXOEc/SONQlf3VdCbHt/LPE1uD/uS441HxkeO34r+NWfZaN206sjwqK25 w/VQX4Gf9LGLJVgyw5i4eIaxpdOqrLO0L30IBgdFCMNsgKLwGiaLgg8wX ceOhidlWKDm8LLfARkEWXEYm6kOjJ9msr7YdQIGMeyUMrRBjBvvRDUBW2 3vf3CJ1dblmGSkMJYs0SoYvlSSasCDSWWBsyWgeownkCwCXLyhbX843C4 3eSWZxe8PaH0sUoTv3ua7tEGqv4MeOP5fKA3BS5/T22Be3Y3F00aqnbZg A==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="381161641" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="381161641" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 03:30:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="820928509" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="820928509" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2022 03:30:19 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p2scz-005k27-02; Wed, 07 Dec 2022 13:30:17 +0200 Date: Wed, 7 Dec 2022 13:30:16 +0200 From: Andy Shevchenko To: Okan Sahin Cc: outreachy@lists.linux.dev, Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , ChiYuan Huang , Lad Prabhakar , Caleb Connolly , Anand Ashok Dumbre , Ramona Bolboaca , William Breathitt Gray , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 5/5] staging: drivers: iio: adc: Adc MAX77541 ADC Support Message-ID: References: <20221207090906.5896-1-okan.sahin@analog.com> <20221207090906.5896-6-okan.sahin@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207090906.5896-6-okan.sahin@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 07, 2022 at 12:08:44PM +0300, Okan Sahin wrote: > This patch add adc support for MAX77541. > > The MAX77541 has an 8-bit Successive Approximation Register (SAR) ADC > with four multiplexers for supporting the telemetry feature Same comment as per patch 2. ... > +#include > +#include > +#include Hmm... > +#include > +#include > +#include > +#include ... > +enum { > + MAX77541_ADC_CH1_I = 0, > + MAX77541_ADC_CH2_I, > + MAX77541_ADC_CH3_I, > + MAX77541_ADC_CH6_I, > + > + MAX77541_ADC_IRQMAX_I, If it's a terminator, drop the trailing comma. > +}; ... > + case MAX77541_ADC_TEMP: > + *val = -273; I believe we have definition for this in units.h. Can you use it? > + *val2 = 0; > + return IIO_VAL_INT_PLUS_MICRO; > + } > +} ... > + *val = 0; > + > + if (reg_val == LOW_RANGE) > + *val2 = 6250; > + else if (reg_val == MID_RANGE) > + *val2 = 12500; > + else if (reg_val == HIGH_RANGE) > + *val2 = 25000; > + else > + return -EINVAL; Can it be provided as a table? ... > + *val = 0; > + > + if (reg_val == LOW_RANGE) > + *val2 = 6250; > + else if (reg_val == MID_RANGE) > + *val2 = 12500; > + else if (reg_val == HIGH_RANGE) > + *val2 = 25000; > + else > + return -EINVAL; Ditto. ... > + Redundant blank line. > +module_platform_driver(max77541_adc_driver); -- With Best Regards, Andy Shevchenko