devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Niedermayr, BENEDIKT" <benedikt.niedermayr@siemens.com>
Cc: "rogerq@kernel.org" <rogerq@kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH v9 1/2] memory: omap-gpmc: wait pin additions
Date: Wed, 7 Dec 2022 17:06:53 +0200	[thread overview]
Message-ID: <Y5CsDefg12Bbg24p@atomide.com> (raw)
In-Reply-To: <ae35cfd12ed3472df20ca5f99bffa8bb7c009199.camel@siemens.com>

* Niedermayr, BENEDIKT <benedikt.niedermayr@siemens.com> [221207 14:52]:
> Hi Tony,
> 
> On Wed, 2022-12-07 at 15:51 +0200, Tony Lindgren wrote:
> > Hi,
> > 
> > * B. Niedermayr <benedikt.niedermayr@siemens.com> [221102 13:21]:
> > > From: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
> > > 
> > > This patch introduces support for setting the wait-pin polarity as well
> > > as using the same wait-pin for different CS regions.
> > 
> > Looks like Linux next commit 89aed3cd5cb9 ("memory: omap-gpmc: wait pin
> > additions") breaks the old smsc911x using devices somehow for nfsroot.
> > 
> Can you explain how this breaking change looks like, in bit more detail?
> I'm a bit confused since the changes on omap-gpmc have nothing in common with
> smsc911x. 

The smsc911x device is on gpmc. It's not found with this change.
See arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi for the configuration.

Regards,

Tony

  reply	other threads:[~2022-12-07 15:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 13:30 [PATCH v9 0/2] gpmc wait pin additions B. Niedermayr
2022-11-02 13:30 ` [PATCH v9 1/2] memory: omap-gpmc: " B. Niedermayr
2022-12-07 13:51   ` Tony Lindgren
2022-12-07 14:52     ` Niedermayr, BENEDIKT
2022-12-07 15:06       ` Tony Lindgren [this message]
2022-12-07 17:28         ` Niedermayr, BENEDIKT
2022-12-08  5:49           ` Tony Lindgren
2022-12-08 15:55             ` Niedermayr, BENEDIKT
2022-12-12  7:16               ` Tony Lindgren
2022-11-02 13:30 ` [PATCH v9 2/2] dt-bindings: memory-controllers: gpmc-child: add wait-pin polarity B. Niedermayr
2022-11-02 14:02 ` [PATCH v9 0/2] gpmc wait pin additions Krzysztof Kozlowski
2022-11-03  8:13   ` Niedermayr, BENEDIKT
2022-11-03 12:37     ` Krzysztof Kozlowski
2022-11-02 14:03 ` Krzysztof Kozlowski
2022-11-03  8:07   ` Niedermayr, BENEDIKT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5CsDefg12Bbg24p@atomide.com \
    --to=tony@atomide.com \
    --cc=benedikt.niedermayr@siemens.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).