From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C12C352A1 for ; Wed, 7 Dec 2022 15:07:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbiLGPHI (ORCPT ); Wed, 7 Dec 2022 10:07:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbiLGPG5 (ORCPT ); Wed, 7 Dec 2022 10:06:57 -0500 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 728A433E; Wed, 7 Dec 2022 07:06:55 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 985A8804D; Wed, 7 Dec 2022 15:06:54 +0000 (UTC) Date: Wed, 7 Dec 2022 17:06:53 +0200 From: Tony Lindgren To: "Niedermayr, BENEDIKT" Cc: "rogerq@kernel.org" , "krzysztof.kozlowski@linaro.org" , "devicetree@vger.kernel.org" , "linux-omap@vger.kernel.org" , "robh+dt@kernel.org" Subject: Re: [PATCH v9 1/2] memory: omap-gpmc: wait pin additions Message-ID: References: <20221102133047.1654449-1-benedikt.niedermayr@siemens.com> <20221102133047.1654449-2-benedikt.niedermayr@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * Niedermayr, BENEDIKT [221207 14:52]: > Hi Tony, > > On Wed, 2022-12-07 at 15:51 +0200, Tony Lindgren wrote: > > Hi, > > > > * B. Niedermayr [221102 13:21]: > > > From: Benedikt Niedermayr > > > > > > This patch introduces support for setting the wait-pin polarity as well > > > as using the same wait-pin for different CS regions. > > > > Looks like Linux next commit 89aed3cd5cb9 ("memory: omap-gpmc: wait pin > > additions") breaks the old smsc911x using devices somehow for nfsroot. > > > Can you explain how this breaking change looks like, in bit more detail? > I'm a bit confused since the changes on omap-gpmc have nothing in common with > smsc911x. The smsc911x device is on gpmc. It's not found with this change. See arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi for the configuration. Regards, Tony