From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA69AC4167B for ; Thu, 8 Dec 2022 23:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbiLHXb2 (ORCPT ); Thu, 8 Dec 2022 18:31:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiLHXb0 (ORCPT ); Thu, 8 Dec 2022 18:31:26 -0500 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463D15F6F5 for ; Thu, 8 Dec 2022 15:31:25 -0800 (PST) Received: by mail-il1-x136.google.com with SMTP id x12so1913209ilg.1 for ; Thu, 08 Dec 2022 15:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FV3wpSUefX/PcYICHHfwY5Z4y5Zte+XPd9H0LpIR36Y=; b=lJ0iS5gPJ4rlcWmv+546tiaO4lzaDKBJkQwcqSe9xUXv5pSttUd6DRVC+XDVam+MVP t0g1XTbaNGl5MK0s80HWMY3uKd/36qpX3Y5n8RzEZ4jr/TlvEsRJtvq9RFBe0KhLLLyC 36gRI5DgIkC0uFWx6t97uYRu9H4k0m+1ZbVWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FV3wpSUefX/PcYICHHfwY5Z4y5Zte+XPd9H0LpIR36Y=; b=Ik/BuZMhVL/bhb/7Ll+tWo5dv7cOWugyDNVoxU8IzNob7qs7K814kJupqvP0wq+LpC /1W7f9qpEucIxiwoDiVs4bgF+eqrSbBri1TtUy4F2lqQ6QKvahrmuX8Bt3kap7/s0QV3 4oERbhYb8t2xz5GUY7hP1pwmydHeeyGQJO2kETZT6whOAw0tGPFfnGCkEr8FXNoG1pS1 LS5vZwh7a7pnv/prv8zHiIJxpvFzCrDkTiaguR6Vt6PBzLBSFmwuq5cNVomkgjhojk1k DnWQsVrfEmYpxAOSAmMXpckK9x1MjQGRl+intK1jsvsgI+Y/0ceS01oF1HWbwXH98VWp FTcw== X-Gm-Message-State: ANoB5pmvMkTt3szowsSCc7j8ETYaEam/DrQK8LTUgWj6uauLoaIIooHA n/P3EPCohQM1qvn85IbwYIAKgw== X-Google-Smtp-Source: AA0mqf6bgTHcg2kInnMk80L1L32E9Q4xc840yl7AcjpfQ/F0Oy5zpG8kBq8XYFt2ZP7TBlg/OUY6SQ== X-Received: by 2002:a92:7302:0:b0:303:41bf:fab5 with SMTP id o2-20020a927302000000b0030341bffab5mr2086390ilc.27.1670542284656; Thu, 08 Dec 2022 15:31:24 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id a1-20020a029401000000b0038a346207cdsm5925554jai.84.2022.12.08.15.31.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 15:31:24 -0800 (PST) Date: Thu, 8 Dec 2022 23:31:23 +0000 From: Matthias Kaehlcke To: Douglas Anderson Cc: Bjorn Andersson , Dmitry Torokhov , swboyd@chromium.org, linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, Yunlong Jia , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arm64: dts: qcom: sc7180: Add trogdor eDP/touchscreen regulator off-on-time Message-ID: References: <20221208192006.1070898-1-dianders@chromium.org> <20221208111910.2.I65ac577411b017eff50e7a4fda254e5583ccdc48@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221208111910.2.I65ac577411b017eff50e7a4fda254e5583ccdc48@changeid> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 08, 2022 at 11:20:03AM -0800, Douglas Anderson wrote: > In general, the timing diagrams for components specify a minimum time > for power cycling the component. When we remove power from a device we > need to let the device fully discharge and get to a quiescent state > before applying power again. If we power a device on too soon then it > might not have fully powered off and might be in a weird in-between / > invalid state. > > eDP panels typically have a time that's at least 500 ms here. You can > see that in Linux's panel-edp driver that nearly every device nit: s/that nearly/nearly/ no need to re-spin just for this. > specifies a "unprepare" time of at least 500 ms. This is a common > minimum and the 500 ms is even in the example in the eDP spec. > > In Linux, the "panel-edp" driver enforces this delay for its own > control of the regulator, but the "panel-edp" driver can't do anything > about other control of the regulator (for instance, by the touchpanel > driver). > > Let's add 500 ms as a board constraint for the regulator that's used > for eDP/touchpanel on trogdor boards. If a given trogdor board stuffs > only panels that can use a shorter time or stuff some panels that need > a larger time then they can manually adjust this timing. > > We'll only do this minimum delay for trogdor devices with eDP (ones > that use either bridge chip), not for devices with MIPI panels. MIPI > panels could have similar constraints but the 500 ms isn't necessarily > as standard and there are no known cases where this delay is needed. > > For most trogdor boards, this doesn't actually seem to affect anything > when testing against shipping Linux. However, with pazqel360 it seems > that this does make a difference. It seems that the touchscreen on > this board _also_ needs some time for the regulator to discharge. That > time is much less than 500 ms, so we'll just put the eDP panel 500 ms > in there since the board constraint should be the "max" of the > components. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke