From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Wolfram Sang <wsa@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, loongarch@lists.linux.dev,
devicetree@vger.kernel.org, Huacai Chen <chenhuacai@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jianmin Lv <lvjianmin@loongson.cn>
Subject: Re: [PATCH V5 1/4] i2c: gpio: Add support on ACPI-based system
Date: Mon, 12 Dec 2022 11:40:40 +0200 [thread overview]
Message-ID: <Y5b3GHiYxblLitvG@smile.fi.intel.com> (raw)
In-Reply-To: <14dcf7b0-2fb1-575f-7e41-f58ce55b920b@loongson.cn>
On Wed, Dec 07, 2022 at 03:10:43PM +0800, Binbin Zhou wrote:
> 在 2022/12/6 23:13, Andy Shevchenko 写道:
> > On Tue, Dec 06, 2022 at 11:16:54AM +0800, Binbin Zhou wrote:
...
> > > -#include <linux/of.h>
> > Cool, but don't you need to add property.h?
>
> Get it, I should have been more careful, maybe I'm still not very sensitive
> to header files.
>
> Now I'm still basically judging based on whether I compile with errors or
> not.
You can generate the include tree by running `make includecheck`
The rule of thumb is to include what you are the direct user of.
With a few exceptions where we have the guarantees that one header
is always included by another (e.g. bits.h included by bitops.h).
> > Otherwise looks good to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-12 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 3:16 [PATCH V5 0/4] i2c: ls2x: Add support for the Loongson-2K/LS7A I2C controller Binbin Zhou
2022-12-06 3:16 ` [PATCH V5 1/4] i2c: gpio: Add support on ACPI-based system Binbin Zhou
2022-12-06 15:13 ` Andy Shevchenko
2022-12-07 7:10 ` Binbin Zhou
2022-12-12 9:40 ` Andy Shevchenko [this message]
2022-12-06 3:16 ` [PATCH V5 2/4] dt-bindings: i2c: add Loongson LS2X I2C controller Binbin Zhou
2022-12-06 3:16 ` [PATCH V5 3/4] i2c: ls2x: Add driver for Loongson-2K/LS7A " Binbin Zhou
2022-12-06 3:17 ` Binbin Zhou
2022-12-06 15:23 ` Andy Shevchenko
2022-12-08 8:55 ` Binbin Zhou
2022-12-12 9:47 ` Andy Shevchenko
2022-12-12 12:41 ` Binbin Zhou
2022-12-06 3:17 ` [PATCH V5 4/4] LoongArch: Enable LS2X I2C in loongson3_defconfig Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5b3GHiYxblLitvG@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).