From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE243C4332F for ; Mon, 12 Dec 2022 09:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231962AbiLLJlM (ORCPT ); Mon, 12 Dec 2022 04:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231963AbiLLJky (ORCPT ); Mon, 12 Dec 2022 04:40:54 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFFD46275; Mon, 12 Dec 2022 01:40:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670838046; x=1702374046; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=qTWDV+Z/hhFb8cx57UqTTsPxzQP16q2k1qLosYDy8aM=; b=S4vYhUuyjHi9OsOohuO3XK0nvKD59Gh3eH6UEtOqS/q3GIH2po4ymyvB w/f6Eq0D6VbIlRw69NVokNso8qy7mTdUl3VvsMcAxpcT04m3313BpwNbP OhaSpvmDBdgnyT0bi5NxU5gfSg+w0EYbfD1E/56Hyz55K0QIh0WCgDC3U tz0MQ+/BlxyiAVjSz+qw8clHyg6OdD9XhfJjKWsyJ0PgGPlTHCmxjg+d5 zzEI2rhpbZHO2XyHzQ+bsoQ5Ogazk6pXR6jqg/Ok7kOaChPhxEYYQ65SQ GHDjnA6yy28On+UMs2ddS5irghFqxIPh5eE8gTR0NSLWvIN1muljCvUJy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="404069031" X-IronPort-AV: E=Sophos;i="5.96,238,1665471600"; d="scan'208";a="404069031" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2022 01:40:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="711612985" X-IronPort-AV: E=Sophos;i="5.96,238,1665471600"; d="scan'208";a="711612985" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 12 Dec 2022 01:40:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p4fIf-008PDA-0p; Mon, 12 Dec 2022 11:40:41 +0200 Date: Mon, 12 Dec 2022 11:40:40 +0200 From: Andy Shevchenko To: Binbin Zhou Cc: Wolfram Sang , Wolfram Sang , Mika Westerberg , linux-i2c@vger.kernel.org, loongarch@lists.linux.dev, devicetree@vger.kernel.org, Huacai Chen , WANG Xuerui , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Jianmin Lv Subject: Re: [PATCH V5 1/4] i2c: gpio: Add support on ACPI-based system Message-ID: References: <0a8a1dec27beea61935adb2a9c2d74e41c86e9b1.1670293176.git.zhoubinbin@loongson.cn> <14dcf7b0-2fb1-575f-7e41-f58ce55b920b@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14dcf7b0-2fb1-575f-7e41-f58ce55b920b@loongson.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 07, 2022 at 03:10:43PM +0800, Binbin Zhou wrote: > 在 2022/12/6 23:13, Andy Shevchenko 写道: > > On Tue, Dec 06, 2022 at 11:16:54AM +0800, Binbin Zhou wrote: ... > > > -#include > > Cool, but don't you need to add property.h? > > Get it, I should have been more careful, maybe I'm still not very sensitive > to header files. > > Now I'm still basically judging based on whether I compile with errors or > not. You can generate the include tree by running `make includecheck` The rule of thumb is to include what you are the direct user of. With a few exceptions where we have the guarantees that one header is always included by another (e.g. bits.h included by bitops.h). > > Otherwise looks good to me. -- With Best Regards, Andy Shevchenko