From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C012C4167B for ; Mon, 12 Dec 2022 13:05:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232154AbiLLNFL (ORCPT ); Mon, 12 Dec 2022 08:05:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbiLLNEu (ORCPT ); Mon, 12 Dec 2022 08:04:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB19D14001 for ; Mon, 12 Dec 2022 05:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670850090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IAcys2kevC/gc9nuZ3z+Y7/oT9oEQ4M5JbDnTp/1RaM=; b=ASbrJ3q7YOv84DiC26fVFxddQJEWj4SelvaQnlFRgPE3LIci0iV2Dks6z6ZlOfk3rUzooA bQr1UpoQf/RI5m+j9+aBXpzvPZ+L6Wd3b0m4iaLrMh485z5qwAkF6/ydgP62H4DApRzs4b DoQfzWhW4lus3rQdWcoajWX0uQyKQBA= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-42-sEaQOTu4PFu3JYRlA_RjSQ-1; Mon, 12 Dec 2022 08:01:29 -0500 X-MC-Unique: sEaQOTu4PFu3JYRlA_RjSQ-1 Received: by mail-io1-f70.google.com with SMTP id r25-20020a6bfc19000000b006e002cb217fso6065350ioh.2 for ; Mon, 12 Dec 2022 05:01:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IAcys2kevC/gc9nuZ3z+Y7/oT9oEQ4M5JbDnTp/1RaM=; b=2KMe3E6UklHI1yA9BCx0dGxjciGRxRZfzl9EgV8Skg974k7l29Xo+nW621HPdSL8gK IEb0/KkhKwaO7Sq+v3L62ijVkHyhISD12kSlfVHTg6S1hlbBs8OdzRAPO9WgRbZaxFAG Rx3G7kFrzRHGR3/wgqYPD6oWTAAkCNEyVLQxzLLaSJ3ndvWPB0AevGyHnTVwdeoovusi WU79bbqe4sW4LBNW6XYTY7qqT2/B9eVWwqwJ/fQupcA4ByagafN/OYo/2K9Hg1mWOgWa sbVX0dwrDG496GT5Osiy+F+U5xIr/mwVzi8XAuDHriBh6hUxtxAovtR3N7y2HqfU9mjR yF0g== X-Gm-Message-State: ANoB5pmHQQUgprpPky0sPPlqPVutZdhihkBmJaffll+kPGDYBJXzRaxb Aslq8gdiSfWowbYfWX0chjatyCkKpAzlLmSO1fe6xWVUYUrUhYbVxEvVoXvLbc1PLy8VqL8bTVi 9t+LBOExDWO5+Bb+A/94gDQ== X-Received: by 2002:a5d:8ad3:0:b0:6d6:d016:b57f with SMTP id e19-20020a5d8ad3000000b006d6d016b57fmr8804457iot.8.1670850088669; Mon, 12 Dec 2022 05:01:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7lMCNzvapRWQgP9Do1GVyF6UNm0BOoIJpWHXZg7697fb7i7kT6Bj/WI5IK4JVElqXRUziw4g== X-Received: by 2002:a5d:8ad3:0:b0:6d6:d016:b57f with SMTP id e19-20020a5d8ad3000000b006d6d016b57fmr8804420iot.8.1670850088386; Mon, 12 Dec 2022 05:01:28 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id q33-20020a027b21000000b00363fe31cf55sm3063507jac.40.2022.12.12.05.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 05:01:27 -0800 (PST) Date: Mon, 12 Dec 2022 08:01:26 -0500 From: Brian Masney To: Shazad Hussain Cc: andersson@kernel.org, johan@kernel.org, Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable pcie2a node Message-ID: References: <20221212122058.597-1-quic_shazhuss@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221212122058.597-1-quic_shazhuss@quicinc.com> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 12, 2022 at 05:50:59PM +0530, Shazad Hussain wrote: > Add the pcie2a, pcie2a_phy, and respective tlmm > nodes that are needed to get pcie 2a controller > enabled on Qdrive3. > > This patch enables 4GB 64bit memory space for > PCIE_2A to have BAR allocations of 64bit pref mem > needed on this Qdrive3 platform with dual SoCs > for root port and switch NT-EP. Hence this ranges > property is overridden in sa8540p-ride.dts only. > > Signed-off-by: Shazad Hussain > --- > Changes since v1: > - Fix ranges property indentation (Konrad) > > This patch depends on below patch series for vreg_l11a. > > [v4] arm64: dts: qcom: sa8540p-ride: enable PCIe support > https://lore.kernel.org/all/20221206161916.315640-1-bmasney@redhat.com/ I verified that this matches what's in downstream. Reviewed-by: Brian Masney I'm not able to test this yet since we're still on an old version of the PCIe switch firmware and I need to get that upgraded first. Note that your patch won't apply to linux-next since the v3 of my pcie3a patch is what was actually merged into the qcom tree. Can you resend? You can move the tlmm node to the bottom and add the PINCTRL comment. I have some i2c and SPI changes that I'll be posting soon where I already made that change but I'll hold off for you to post a new version and base on top of yours. Brian