From: Johan Hovold <johan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: correct SPMI bus address cells
Date: Tue, 13 Dec 2022 09:12:52 +0100 [thread overview]
Message-ID: <Y5g0BAc1ix1+j3r3@hovoldconsulting.com> (raw)
In-Reply-To: <20221212133303.39610-3-krzysztof.kozlowski@linaro.org>
On Mon, Dec 12, 2022 at 02:33:01PM +0100, Krzysztof Kozlowski wrote:
> The SPMI bus uses two address cells and zero size cells (secoond reg
> entry - SPMI_USID - is not the size):
>
> spmi@c440000: #address-cells:0:0: 2 was expected
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 27f5c2f82338..3cb4ca6c53eb 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1947,8 +1947,8 @@ spmi_bus: spmi@c440000 {
> interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
> qcom,ee = <0>;
> qcom,channel = <0>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> + #address-cells = <2>;
> + #size-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <4>;
> };
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
next prev parent reply other threads:[~2022-12-13 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 13:32 [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Krzysztof Kozlowski
2022-12-12 13:33 ` [PATCH 2/4] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
2022-12-12 13:35 ` Konrad Dybcio
2022-12-12 19:06 ` Stephen Boyd
2022-12-12 13:33 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2022-12-12 13:36 ` Konrad Dybcio
2022-12-12 19:07 ` Stephen Boyd
2022-12-13 8:12 ` Johan Hovold [this message]
2022-12-12 13:33 ` [PATCH 4/4] arm64: dts: qcom: rename AOSS QMP node to pmu Krzysztof Kozlowski
2022-12-12 13:38 ` Konrad Dybcio
2022-12-12 13:46 ` Krzysztof Kozlowski
2022-12-12 19:08 ` Stephen Boyd
2022-12-13 7:54 ` Krzysztof Kozlowski
2022-12-12 13:35 ` [PATCH 1/4] arm64: dts: qcom: sc7180: correct SPMI bus address cells Konrad Dybcio
2022-12-12 13:44 ` Krzysztof Kozlowski
2022-12-12 19:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5g0BAc1ix1+j3r3@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).