From: Johan Hovold <johan@kernel.org>
To: Shazad Hussain <quic_shazhuss@quicinc.com>
Cc: Brian Masney <bmasney@redhat.com>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ahalaney@redhat.com, echanude@redhat.com
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21
Date: Tue, 13 Dec 2022 16:42:55 +0100 [thread overview]
Message-ID: <Y5idf5dP2ttBSOUa@hovoldconsulting.com> (raw)
In-Reply-To: <Y5icyo7I5ZGAL02q@hovoldconsulting.com>
On Tue, Dec 13, 2022 at 04:39:54PM +0100, Johan Hovold wrote:
> On Tue, Dec 13, 2022 at 09:04:39PM +0530, Shazad Hussain wrote:
> > On 12/13/2022 8:58 PM, Johan Hovold wrote:
> > >> So qup2_i2c18 becomes qup2_i2c2. Would I use the flat naming scheme for
> > >> the alias like so?
> > >>
> > >> aliases {
> > >> i2c18 = &qup2_i2c2;
> > >> }
> > >
> > > Or perhaps the i2c controllers should use a zero-based index instead of
> > > being named after the serial engines (e.g. as we do for the console
> > > uart).
> > >
> > > How are they named in the schematics?
> >
> > We should use from 0 to N.
>
> With N being 23 after the number of serial engines, or the number of
> available i2c buses on a particular board minus one?
Looks like the more recent Qualcomm platforms use aliases that reflect
the engine number (i.e. 0 to 23) for i2c and spi.
Johan
next prev parent reply other threads:[~2022-12-13 15:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 18:23 [PATCH 0/4] arm64: dts: qcom: sc8280xp: add i2c and spi nodes Brian Masney
2022-12-12 18:23 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Brian Masney
2022-12-12 18:48 ` Konrad Dybcio
2022-12-13 14:54 ` Johan Hovold
2022-12-13 15:04 ` Shazad Hussain
2022-12-13 15:19 ` Johan Hovold
2022-12-13 15:05 ` Brian Masney
2022-12-13 15:12 ` Brian Masney
2022-12-13 15:28 ` Johan Hovold
2022-12-13 15:34 ` Shazad Hussain
2022-12-13 15:39 ` Johan Hovold
2022-12-13 15:42 ` Johan Hovold [this message]
2022-12-13 15:44 ` Konrad Dybcio
2022-12-13 16:15 ` Johan Hovold
2022-12-13 15:45 ` Shazad Hussain
2022-12-13 15:17 ` Johan Hovold
2022-12-13 15:29 ` Konrad Dybcio
2022-12-13 15:32 ` Johan Hovold
2022-12-13 15:59 ` Brian Masney
2022-12-13 16:22 ` Johan Hovold
2022-12-12 18:23 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp: add missing i2c nodes Brian Masney
2022-12-12 18:23 ` [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes Brian Masney
2022-12-13 7:18 ` Shazad Hussain
2022-12-13 14:48 ` Konrad Dybcio
2022-12-14 12:30 ` Brian Masney
2022-12-14 12:52 ` Krzysztof Kozlowski
2022-12-14 14:19 ` Brian Masney
2022-12-14 12:53 ` Konrad Dybcio
2022-12-14 15:36 ` Shazad Hussain
2022-12-14 16:24 ` Brian Masney
2022-12-13 14:59 ` Johan Hovold
2022-12-14 12:51 ` Krzysztof Kozlowski
2022-12-12 18:23 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: add missing spi nodes Brian Masney
2022-12-13 7:16 ` Shazad Hussain
2022-12-13 12:27 ` Brian Masney
2022-12-13 12:47 ` Mark Brown
2022-12-13 13:02 ` Krzysztof Kozlowski
2022-12-13 13:08 ` Javier Martinez Canillas
2022-12-13 14:36 ` Brian Masney
2022-12-13 14:45 ` Shazad Hussain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5idf5dP2ttBSOUa@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_shazhuss@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).