From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9567CC4332F for ; Tue, 13 Dec 2022 16:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234735AbiLMQWF (ORCPT ); Tue, 13 Dec 2022 11:22:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235691AbiLMQV7 (ORCPT ); Tue, 13 Dec 2022 11:21:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35433218A4; Tue, 13 Dec 2022 08:21:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEB21615DB; Tue, 13 Dec 2022 16:21:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC71AC433EF; Tue, 13 Dec 2022 16:21:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670948518; bh=Jk85M6LBW3nYMcfFJnJRi+cnyvWHxdySu0OtkbTJtqM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HDlhvcn+PZXyb6Wblwz3d1R3uGiy7rey5CJRz1fBELd4XzT3rMmdh5rs7PDsDHDbP Oedvmp8l8ua+Fs8U+nof3cLEk/NIrXSbTVJQlNbkR3RrC3Tc7YJtviivQR3tVaiz51 V6SpILsaBpTFiPVS51k9sRilAs/Ii6nrH0zfcZt7Jzy15yVRc8K2t1OgvsELKmrI6S tGG9ybDu0Fyv3Ck7DuGeYkYxyuASMxixknSmZ7g/dxgfSVgKw/c0x8KPDP/KxAuFLY SKEQft681VGwGRrowJyIaXXguRK5zSoJ38RT5xssNKbCSo0ZnbioTWHMnD2NVw7dd5 U5B2CCn67ds7A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1p582y-0005rW-39; Tue, 13 Dec 2022 17:22:24 +0100 Date: Tue, 13 Dec 2022 17:22:24 +0100 From: Johan Hovold To: Brian Masney Cc: Konrad Dybcio , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Message-ID: References: <20221212182314.1902632-1-bmasney@redhat.com> <20221212182314.1902632-2-bmasney@redhat.com> <114e960f-3b63-8c8f-9d4a-87173049d730@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Dec 13, 2022 at 10:59:47AM -0500, Brian Masney wrote: > I noticed another inconsistency with sc8280xp.dtsi compared to other > platforms. I left off all of the pin mappings in sc8280xp.dtsi and > added them to the sa8540-ride.dts file since the existing sc8280xp.dtsi > file contains no pin mappings. Other platforms such as sm8450.dtsi, > sm8350.dtsi, and sm8250.dtsi contain the geni pin mappings. My > understanding is that these geni pins are fixed within the SoC and > don't change with the different boards. Should I also add the geni > pin mappings to sc8280xp.dtsi? The pins are fixed but the pin configuration is still board specific. This came up earlier and we decided that keeping all pin configuration in the board dts was the way to go (e.g. for consistency and as it allows the integrator to easily review the actual configuration). Johan