From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <quic_bjorande@quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Kalyan Thota <quic_kalyant@quicinc.com>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Johan Hovold <johan+linaro@kernel.org>,
Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP
Date: Tue, 13 Dec 2022 17:26:36 +0100 [thread overview]
Message-ID: <Y5invNFKLBKy30v1@hovoldconsulting.com> (raw)
In-Reply-To: <20221213151012.GB16520@core-thresher1.qualcomm.com>
On Tue, Dec 13, 2022 at 07:10:14AM -0800, Bjorn Andersson wrote:
> On Fri, Dec 09, 2022 at 11:35:23AM +0100, Johan Hovold wrote:
> > > + edp_reg_en: edp-reg-en-state {
> > > + pins = "gpio25";
> > > + function = "gpio";
> > > + output-enable;
> >
> > 'output-enable' is not valid for tlmm and causes the settings to be
> > rejected:
> >
> > sc8280xp-tlmm f100000.pinctrl: pin_config_group_set op failed for group 25
> > reg-fixed-voltage regulator-edp-3p3: Error applying setting, reverse things back
> >
>
> Thanks for spotting that, it doesn't seem to be needed for the gpio-regulator
> driver anyways...
I noticed that the firmware on both CRD and X13s sets the drive strength
to 16 here. Should we specify that too (and disable the pull up)
instead of relying on the firmware configuration?
Johan
next prev parent reply other threads:[~2022-12-13 16:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 22:00 [PATCH v5 00/12] drm/msm: Add SC8280XP support Bjorn Andersson
2022-12-07 22:00 ` [PATCH v5 01/12] dt-bindings: display/msm: Add binding for SC8280XP MDSS Bjorn Andersson
2022-12-07 22:00 ` [PATCH v5 02/12] drm/msm/dpu: Introduce SC8280XP Bjorn Andersson
2022-12-07 23:30 ` Dmitry Baryshkov
2022-12-08 23:31 ` Kuogee Hsieh
2023-01-08 21:47 ` Dmitry Baryshkov
2022-12-07 22:00 ` [PATCH v5 03/12] drm/msm: Introduce SC8280XP MDSS Bjorn Andersson
2022-12-08 23:32 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 04/12] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles Bjorn Andersson
2022-12-08 23:15 ` Dmitry Baryshkov
2022-12-07 22:00 ` [PATCH v5 05/12] drm/msm/dp: Stop using DP id as index in desc Bjorn Andersson
2022-12-08 23:12 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 06/12] drm/msm/dp: Add DP and EDP compatibles for SC8280XP Bjorn Andersson
2022-12-08 23:13 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 07/12] drm/msm/dp: Add SDM845 DisplayPort instance Bjorn Andersson
2022-12-08 23:14 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 08/12] drm/msm/dp: Rely on hpd_enable/disable callbacks Bjorn Andersson
2022-12-08 23:14 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 09/12] drm/msm/dp: Implement hpd_notify() Bjorn Andersson
2022-12-08 23:15 ` Kuogee Hsieh
2022-12-07 22:00 ` [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks Bjorn Andersson
2022-12-09 10:52 ` Johan Hovold
2023-01-18 2:58 ` Dmitry Baryshkov
2023-01-19 18:12 ` Bjorn Andersson
2022-12-07 22:00 ` [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP Bjorn Andersson
2022-12-09 10:35 ` Johan Hovold
2022-12-13 15:10 ` Bjorn Andersson
2022-12-13 16:26 ` Johan Hovold [this message]
2022-12-09 11:30 ` Dmitry Baryshkov
2022-12-07 22:00 ` [PATCH v5 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances Bjorn Andersson
2022-12-09 10:44 ` Johan Hovold
2022-12-09 2:49 ` [PATCH v5 00/12] drm/msm: Add SC8280XP support Steev Klimaszewski
2023-01-09 22:41 ` Dmitry Baryshkov
2023-01-09 23:43 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5invNFKLBKy30v1@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).