From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81077C4332F for ; Wed, 14 Dec 2022 09:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiLNJsA (ORCPT ); Wed, 14 Dec 2022 04:48:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbiLNJsA (ORCPT ); Wed, 14 Dec 2022 04:48:00 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 497935FDE; Wed, 14 Dec 2022 01:47:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D9D04618B8; Wed, 14 Dec 2022 09:47:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB066C433EF; Wed, 14 Dec 2022 09:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671011277; bh=UodjR3AssLTk+DhzR2XZAUn0vUG5IFVWg5o01B3CUrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F++yXQevhUPn6jfi1j78hVDYpaGOI3WfEUlPRyE+5F++0Gg+02lD65eBoWtz1hMlw /+HqpxXga4zJTDrpN5mtoIk3bKrUYtxOpFRKyHNDyDOsAoSCadRUfRJAMJny7AUvPw 4Mp2RXeMnvjSluKYcozDIUtKcxHOxHqHWyzlvecFAeC13cY6TDX0a+GJGDCYXCVUOS hz+OnapB7KD3iLVDelZvCLL1lEVBF/9fv7VRMasQxZXMviT40QXzwI8eQMvvHJepar /IPtDrC0+E/toFGBzDfkWRWWdxt5twdbdFt77bgAQgSwNhWS2AyzXi2ck9oAHX7BgO Zn4NR3getB4Ow== Date: Wed, 14 Dec 2022 09:47:52 +0000 From: Lee Jones To: Naresh Solanki Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Patrick Rudolph , Marcello Sylvester Bauer Subject: Re: [PATCH v11 2/2] mfd: max597x: Add support for MAX5970 and MAX5978 Message-ID: References: <20221116205822.1128275-1-Naresh.Solanki@9elements.com> <20221116205822.1128275-3-Naresh.Solanki@9elements.com> <5d9e41b8-7b2a-d60b-3e92-641cea5a9f4a@9elements.com> <921915e5-6b36-9d2d-ebd7-632403e3086a@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <921915e5-6b36-9d2d-ebd7-632403e3086a@9elements.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 14 Dec 2022, Naresh Solanki wrote: > Hi Lee > > On 08-12-2022 05:53 pm, Lee Jones wrote: > > On Fri, 18 Nov 2022, Naresh Solanki wrote: > > > > > > > > > > > On 17-11-2022 03:45 pm, Lee Jones wrote: > > > > On Wed, 16 Nov 2022, Naresh Solanki wrote: > > > > > > > > > From: Patrick Rudolph > > > > > > > > > > Implement a regulator driver with IRQ support for fault management. > > > > > Written against documentation [1] and [2] and tested on real hardware. > > > > > > > > > > Every channel has its own regulator supplies nammed 'vss1-supply' and > > > > > 'vss2-supply'. The regulator supply is used to determine the output > > > > > voltage, as the smart switch provides no output regulation. > > > > > The driver requires the 'shunt-resistor-micro-ohms' property to be > > > > > present in Device Tree to properly calculate current related > > > > > values. > > > > > > > > > > Datasheet links: > > > > > 1: https://datasheets.maximintegrated.com/en/ds/MAX5970.pdf > > > > > 2: https://datasheets.maximintegrated.com/en/ds/MAX5978.pdf > > > > > > > > > > Signed-off-by: Patrick Rudolph > > > > > Co-developed-by: Marcello Sylvester Bauer > > > > > Signed-off-by: Marcello Sylvester Bauer > > > > > Co-developed-by: Naresh Solanki > > > > > Signed-off-by: Naresh Solanki > > > > > --- > > > > > drivers/mfd/Kconfig | 12 +++++ > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/max597x.c | 93 +++++++++++++++++++++++++++++++++ > > > > > include/linux/mfd/max597x.h | 101 ++++++++++++++++++++++++++++++++++++ > > > > > 4 files changed, 207 insertions(+) > > > > > create mode 100644 drivers/mfd/max597x.c > > > > > create mode 100644 include/linux/mfd/max597x.h > > > > > > > > Ignoring my comments won't make them go away. :) > > > > > > > > Please tell me why you need a whole new driver, instead of adding > > > > support to simple-mfd-i2c? > > > > > > > I felt current implementation to be simpler, clearer & straight forward. > > > > If you can make it work with simple-mfd-i2c, please do so. > simple-mfd-i2c doesn't has mechanism to pass device type(max5978 vs > max5970). `git grep silergy,sy7636a -- drivers/mfd` > > No need to submit an entirely new driver for these simple use-cases. -- Lee Jones [李琼斯]