From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ADCBC4332F for ; Wed, 14 Dec 2022 16:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239013AbiLNQZn (ORCPT ); Wed, 14 Dec 2022 11:25:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238990AbiLNQZ1 (ORCPT ); Wed, 14 Dec 2022 11:25:27 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F710659D for ; Wed, 14 Dec 2022 08:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671035084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KBre76ofS18R3kxBaLYSoFNysmFxJK5f/1IE6UR16bc=; b=JC9ECwKHP015hsa3VIylzqYw0az/shkSIGMmM9luPdpyhO5WnVhht46k7H39GMIPzvHhat g1hN6fnTnVrrP4XDJYKWHlQdhcF5TXovzNWwdbZFbhCrKrPosgCjtknUIpmQHgY3XgU9oN /Zg6Jt1r5nqwBxSnwArjM4AvziFn8M0= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-119-HlNjRiOSNEqFd0mI_qilFg-1; Wed, 14 Dec 2022 11:24:35 -0500 X-MC-Unique: HlNjRiOSNEqFd0mI_qilFg-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-410f1a84ed2so2429207b3.15 for ; Wed, 14 Dec 2022 08:24:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBre76ofS18R3kxBaLYSoFNysmFxJK5f/1IE6UR16bc=; b=Hy8gdqyeS31VPk5FB1WEdutUmgUTHEAKUPVzQoFfmWYP2+nRgWL9MBU+Dxp69d4Nyn PJizuQN17/Hm32+TFp8z4mjCUNJOFMaC3gD+qNqHU6hB9F7ZTKmYztOkCoLz+qIuWNM9 FN3NuhHxdINfpE8ByC07xoQxhC/cusJqWcT2JdohhaD+7iRaFRIhxaxYJeoC7oB+8Qnx 6IHs7COy3uN2MCLK/Xo20ruRqxBun8UzRRmZnwH0HI8DB6qDTcK3RYdIComqjoWNQcgO PPQwMTzW8uX/1neQ1RV5luoWuyLK7BVKkLEJO/vAONA3ILLdRrFaOirYq56bxnwKy37B Prqw== X-Gm-Message-State: ANoB5pm/aHWKf2eTAnP8gJvKQZd0vgIQpa1pd3ExUT6gusDWTUcCH+im +bpFnsImkkpdv0japPBSHCOjk3R6Zf6+LHFYqKxn2C+VppoHRsEHUOCgaKGzjnFrNQZvkawY5BP Loiiwliaym9opma7OaGk/tw== X-Received: by 2002:a05:7500:79f:b0:eb:900:b86b with SMTP id cx31-20020a057500079f00b000eb0900b86bmr2907185gab.56.1671035074621; Wed, 14 Dec 2022 08:24:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5bIhNsTqRfwBoppu0IUDuVsmJ/FPH+vXpBDKTREuR0ShXKDiUVu3JFNpqSjU4/SW4TtxQ4Aw== X-Received: by 2002:a05:7500:79f:b0:eb:900:b86b with SMTP id cx31-20020a057500079f00b000eb0900b86bmr2907172gab.56.1671035074270; Wed, 14 Dec 2022 08:24:34 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id bm25-20020a05620a199900b006fa4cac54a5sm10211444qkb.72.2022.12.14.08.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 08:24:33 -0800 (PST) Date: Wed, 14 Dec 2022 11:24:32 -0500 From: Brian Masney To: Shazad Hussain Cc: Konrad Dybcio , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes Message-ID: References: <20221212182314.1902632-1-bmasney@redhat.com> <20221212182314.1902632-4-bmasney@redhat.com> <309b3fad-933c-6c45-5cd7-4e082da62c15@linaro.org> <6ab9171e-127b-12f3-cfe6-0fbf2b37080c@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ab9171e-127b-12f3-cfe6-0fbf2b37080c@quicinc.com> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Dec 14, 2022 at 09:06:48PM +0530, Shazad Hussain wrote: > > i2c0_default: i2c0-default-state { > > pins = "gpio135", "gpio136"; > > function = "qup15"; > > drive-strength = <2>; > > bias-pull-up; > > }; > > > > This is the default config we should use. OK, I'll stick with this config. > > Shazad: 'i2cdetect -a -y $BUSNUM) shows that all 5 buses have the same > > addresses listening. Is that expected? That seems a bit odd to me. > > > > Brian, even I haven't checked with all enabled, let me check this on other > projects and with downstream as well and get back to you. I'll post my v2 in a little bit so that you can test it. Brian