From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FDEC4167B for ; Thu, 15 Dec 2022 16:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbiLOQqQ (ORCPT ); Thu, 15 Dec 2022 11:46:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230289AbiLOQqP (ORCPT ); Thu, 15 Dec 2022 11:46:15 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9E1517880; Thu, 15 Dec 2022 08:46:12 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 659B9327; Thu, 15 Dec 2022 17:46:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671122770; bh=F428qaVY9pfEF7UHtueOFNcG2/B9dH3V7pfjh3Snqkc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nbslu5e0Ok/NimmZyjDUMGYgWzmxLGljcvRYzX8CYiEQNm9aXvfPaneWpKaqbpIsq lNZqN6nRCCdGW+oG/g3ogybQpLRemrE4wtOBqN9CFIb1+RW6qHkzEVNWVHVihMoJht QgLr0kPhmioP49QYuwxLYAD+X7JLCXdMRrqHr8bU= Date: Thu, 15 Dec 2022 18:46:06 +0200 From: Laurent Pinchart To: Rob Herring Cc: Kieran Bingham , devicetree@vger.kernel.org, linux-media@vger.kernel.org, Jacopo Mondi , Niklas =?utf-8?Q?S=C3=B6derlund?= , Krzysztof Kozlowski , Thomas Nizan , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 02/12] dt-bindings: media: i2c: max9286: Add property to select I2C speed Message-ID: References: <20221214233825.13050-1-laurent.pinchart+renesas@ideasonboard.com> <20221214233825.13050-3-laurent.pinchart+renesas@ideasonboard.com> <167111060968.3140791.14917058235505688958.robh@kernel.org> <20221215162216.GA141183-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221215162216.GA141183-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Thu, Dec 15, 2022 at 10:22:16AM -0600, Rob Herring wrote: > On Thu, Dec 15, 2022 at 03:43:28PM +0200, Laurent Pinchart wrote: > > On Thu, Dec 15, 2022 at 07:24:38AM -0600, Rob Herring wrote: > > > On Thu, 15 Dec 2022 01:38:15 +0200, Laurent Pinchart wrote: > > > > The I2C speed on the remote side (the I2C master bus of the connected > > > > serializers) is configurable, and doesn't need to match the speed of the > > > > local bus (the slave bus of the MAX9286). All remote buses must use the > > > > same speed, and the MAX9286 needs to be programmed accordingly. Add a > > > > new DT property to select the speed to make it configurable. > > > > > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Rob Herring > > > > --- > > > > Changes since v2: > > > > > > > > - Rename property to maxim,i2c-remote-bus-hz > > > > - Specify the property type > > > > --- > > > > .../devicetree/bindings/media/i2c/maxim,max9286.yaml | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml: properties:maxim,i2c-remote-bus-hz: '$ref' should not be valid under {'const': '$ref'} > > > hint: Standard unit suffix properties don't need a type $ref > > > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > > > > I wonder how I missed that, as I've run dt_binding_check before > > submitting. I'll fix it. > > > > I'm a bit surprised though, all unit-suffixed properties use 32-bit > > integers in the DT schema, while I can imagine that some may need a > > 64-bit integer. What's the recommendation in that case ? > > Use -mhz. I expected that answer :-) It's not an issue with this specific property, so I'm fine. If I ever run into the need of a 64-bit Hz value to have both range and precision, we'll talk about it then :-) I don't expect that to be very common. > Anything outside the norm we have to special case in > property-units.yaml. -- Regards, Laurent Pinchart