Re: [PATCH v3.1 02/12] dt-bindings: media: i2c: max9286: Add property to select I2C speed

Jacopo Mondi
2022-12-16T10:05:16Z

Hi Laurent

On Fri, Dec 16, 2022 at 02:45:00AM +0200, Laurent Pinchart wrote:
> The I2C speed on the remote side (the I2C master bus of the connected
> serializers) is configurable, and doesn't need to match the speed of the
> local bus (the slave bus of the MAX9286). All remote buses must use the
> same speed, and the MAX9286 needs to be programmed accordingly. Add a
> new DT property to select the speed to make it configurable.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
j

> ---
> Changes since v3:
>
> - Drop the property type
> - Add maxim,i2c-remote-bus-hz property to example
>
> Changes since v2:
>
> - Rename property to maxim,i2c-remote-bus-hz
> - Specify the property type
> ---
> .../devicetree/bindings/media/i2c/maxim,max9286.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> index 4f28690eabcd..75c2d8b8c809 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml
> @@ -50,6 +50,13 @@ properties:
> '#gpio-cells':
> const: 2
>
> + maxim,i2c-remote-bus-hz:
> + enum: [ 8470, 28300, 84700, 105000, 173000, 339000, 533000, 837000 ]
> + default: 105000
> + description: |
> + The I2C clock frequency for the remote I2C buses. The value must match
> + the configuration of the remote serializers.
> +
> maxim,reverse-channel-microvolt:
> minimum: 30000
> maximum: 200000
> @@ -234,6 +241,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
>
> + maxim,i2c-remote-bus-hz = <339000>;
> maxim,reverse-channel-microvolt = <170000>;
>
> ports {
> --
> Regards,
>
> Laurent Pinchart
>