From: Matthias Kaehlcke <mka@chromium.org>
To: Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards
Date: Tue, 20 Dec 2022 16:47:14 +0000 [thread overview]
Message-ID: <Y6HnElz32///ctIB@google.com> (raw)
In-Reply-To: <e269300d-539e-9eb8-8b3c-d309f3abca1b@quicinc.com>
On Tue, Dec 20, 2022 at 09:50:06PM +0530, Rajendra Nayak wrote:
>
>
> On 12/20/2022 8:00 PM, Matthias Kaehlcke wrote:
> > On Tue, Dec 20, 2022 at 10:30:32AM +0530, Rajendra Nayak wrote:
> > >
> > > On 12/16/2022 7:49 PM, Matthias Kaehlcke wrote:
> > > > On Fri, Dec 16, 2022 at 04:59:17PM +0530, Rajendra Nayak wrote:
> > > > > Add compatibles for the Pro SKU of the sc7280 CRD boards
> > > > > which come with a Pro variant of the qcard.
> > > > > The Pro qcard variant has smps9 from pm8350c ganged up with
> > > > > smps7 and smps8.
> > > > >
> > > > > Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > > > ---
> > > > > v4 changes:
> > > > > Added the zoglin-sku1536 compatible along with hoglin-sku1536.
> > > > > Zoglin is same as the Hoglin variant, with the SPI Flash reduced
> > > > > from 64MB to 8MB
> > > > >
> > > > > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
> > > > > 1 file changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > > > index 1b5ac6b02bc5..07771d4c91bd 100644
> > > > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > > > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > > > > @@ -558,6 +558,12 @@ properties:
> > > > > - const: google,hoglin
> > > > > - const: qcom,sc7280
> > > > > + - description: Qualcomm Technologies, Inc. sc7280 CRD Pro platform (newest rev)
> > > > > + items:
> > > > > + - const: google,zoglin-sku1536
> > > > > + - const: google,hoglin-sku1536
> > > >
> > > > Is there actually such a thing as a 'hoglin-sku1536', i.e. the Pro qcard
> > > > with 64MB of SPI flash, or do they all have 8MB of flash?
> > >
> > > The SPI flash is on the CRD mother-board and not on the qcards, so if you replace
> > > the qcards on the CRDs with 64MB flash you would need the hoglin-sku1536 to
> > > boot on those.
> >
> > With such a configuration how does the bootloader know it should pass the kernel
> > the device tree for 'hoglin-sku1536' (pro) and not the non-pro variant? IIUC the
> > device tree is selected based on pin strappings on the mother-board, not the
> > qcard.
>
> The device tree is selected based on the pin strappings _and_ additional logic
> to dynamically identify modem/non-modem(wifi) as well as pro/non-pro SKUs which
> was added in the bootloaders.
Thanks for the clarification!
next prev parent reply other threads:[~2022-12-20 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 11:29 [PATCH v4 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Rajendra Nayak
2022-12-16 11:29 ` [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add a herobrine CRD Pro SKU Rajendra Nayak
2022-12-16 14:19 ` [PATCH v4 1/2] dt-bindings: arm: qcom: Document the sc7280 CRD Pro boards Matthias Kaehlcke
2022-12-20 5:00 ` Rajendra Nayak
2022-12-20 14:30 ` Matthias Kaehlcke
2022-12-20 16:20 ` Rajendra Nayak
2022-12-20 16:47 ` Matthias Kaehlcke [this message]
2022-12-20 17:11 ` Dmitry Baryshkov
2023-01-09 21:00 ` Doug Anderson
2023-01-09 21:36 ` Dmitry Baryshkov
2023-01-09 21:42 ` Doug Anderson
2023-01-10 4:21 ` Rajendra Nayak
2023-01-27 0:20 ` Doug Anderson
2023-01-27 11:37 ` Rajendra Nayak
2023-02-03 23:28 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6HnElz32///ctIB@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).