From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB35C4167B for ; Wed, 21 Dec 2022 00:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234029AbiLUAAM (ORCPT ); Tue, 20 Dec 2022 19:00:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbiLUAAL (ORCPT ); Tue, 20 Dec 2022 19:00:11 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E1871EAE9; Tue, 20 Dec 2022 16:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ZWey8MiaU6pEkm7hu7YYoSQxra2dhDL6Zkj1bzILagQ=; b=O0UxIqJ60w5HMEjz8xkTqvGuen ZgvW+OioAEwwWSbYrTEfGTQRzaFDdeO0WbMpEEPoPuD2Y5FBrYlc21IhfXUQ4dBrNC8nYfyHPiJua xdY0TG+CO5BLg1g89/zHyL4npN7OEFeEVujsCK6lHvtFUPQTJ6xU/FZa8xz30QOX1Y8w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p7mWZ-0008IM-MY; Wed, 21 Dec 2022 00:59:55 +0100 Date: Wed, 21 Dec 2022 00:59:55 +0100 From: Andrew Lunn To: Christian Marangi Cc: "Russell King (Oracle)" , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Pavel Machek , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-leds@vger.kernel.org, Tim Harvey , Alexander Stein , Rasmus Villemoes Subject: Re: [PATCH v7 06/11] leds: trigger: netdev: add hardware control support Message-ID: References: <20221214235438.30271-1-ansuelsmth@gmail.com> <20221214235438.30271-7-ansuelsmth@gmail.com> <639ca665.1c0a0220.ae24f.9d06@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <639ca665.1c0a0220.ae24f.9d06@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > One thought on this approach though - if one has a PHY that supports > > "activity" but not independent "rx" and "tx" activity indications > > and it doesn't support software control, how would one enable activity > > mode? There isn't a way to simultaneously enable both at the same > > time... However, I need to check whether there are any PHYs that fall > > into this category. > > > > Problem is that for such feature and to have at least something working > we need to face compromise. We really can't support each switch feature > and have a generic API for everything. I agree we need to make compromises. We cannot support every LED feature of every PHY, they are simply too diverse. Hopefully we can support some features of every PHY. In the worst case, a PHY simply cannot be controlled via this method, which is the current state today. So it is not worse off. Andrew