From: Chester Lin <clin@suse.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Andrei Stefanescu" <andrei.stefanescu@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Andreas Färber" <afaerber@suse.de>, dl-S32 <S32@nxp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Larisa Ileana Grigore" <larisa.grigore@nxp.com>,
"Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@oss.nxp.com>,
"Matthias Brugger" <mbrugger@suse.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
Date: Wed, 21 Dec 2022 21:52:28 +0800 [thread overview]
Message-ID: <Y6MPnJ27IKFiNltl@linux-8mug> (raw)
In-Reply-To: <5c0e7f2f-94e1-c6d4-d848-f90e29eead10@linaro.org>
Hi Krzysztof and Andrei,
Thanks for reviewing this patch!
On Wed, Dec 21, 2022 at 01:30:12PM +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 13:28, Andrei Stefanescu wrote:
> > Hi Chester,
> >
> >> +patternProperties:
> >> + '-pins$':
> >
> > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.
>
> You cannot have underscores as node names, so what do you mean here? You
Krzysztof is right, and Rob also reminded me in his comments in v1:
https://lore.kernel.org/linux-arm-kernel/20221102154903.GA3726664-robh@kernel.org/
Regards,
Chester
> need to fix your DTS not introduce bad practices to mainline kernel.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-12-21 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:32 [PATCH v3 0/2] Add pinctrl support for S32 SoC family Chester Lin
2022-12-21 7:32 ` [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Chester Lin
2022-12-21 12:28 ` Andrei Stefanescu
2022-12-21 12:30 ` Krzysztof Kozlowski
2022-12-21 13:52 ` Chester Lin [this message]
2022-12-22 11:28 ` Krzysztof Kozlowski
2023-01-09 7:04 ` Chester Lin
2023-01-09 9:08 ` Krzysztof Kozlowski
2022-12-21 7:32 ` [PATCH v3 2/2] pinctrl: add NXP S32 SoC family support Chester Lin
2023-01-09 13:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6MPnJ27IKFiNltl@linux-8mug \
--to=clin@suse.com \
--cc=S32@nxp.com \
--cc=afaerber@suse.de \
--cc=andrei.stefanescu@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=larisa.grigore@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).