From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2F1C41535 for ; Fri, 23 Dec 2022 12:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235673AbiLWMXH (ORCPT ); Fri, 23 Dec 2022 07:23:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbiLWMXG (ORCPT ); Fri, 23 Dec 2022 07:23:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A86D9E73 for ; Fri, 23 Dec 2022 04:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671798139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S1HwigiBXzR+33Qj15n947bgxDdgr8XCfr3PoMuFRgU=; b=XzuGHkrK4ZVj0bbyBAf42ZNl7u3kP8Ssk5+g1kYC/ot9xMzUyeRytp8X/wDYHYkA5CiC0p Q6GuSUgoEkXgE6otYhYVo9yuc+2ve8MxEtjoE4iOzlBArVpdANu+79jwOBwpalkP1TeTrv rNYWFweJkeEMgXdEIAmrTIZnFmIyYD0= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-43-OCH4AOwfMOeZeeh2pAQPmg-1; Fri, 23 Dec 2022 07:22:17 -0500 X-MC-Unique: OCH4AOwfMOeZeeh2pAQPmg-1 Received: by mail-qk1-f199.google.com with SMTP id bq39-20020a05620a46a700b006ffd5db9fe9so3112620qkb.2 for ; Fri, 23 Dec 2022 04:22:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S1HwigiBXzR+33Qj15n947bgxDdgr8XCfr3PoMuFRgU=; b=XvNfPOwl5TCKEBNkmTSREqu/rIEvL6kZXy6+GiPRK5wjbwXyavxNdsVmtixd0+22JX E+AQ5oJQKEamExMIRAJk0ncSqJN2qPGQj9brXfs7GdOkMW1Eg56w0fSsYMw4wEFRN5Jf hnYikfqvwMrBk59K4jknEV327hnhSCs/seeBHvLxeNk+x89Gb54hR0tbyDZ8rXTNK2V/ aU00aH57QNteEZTlfbg5fQUUrTWPbZxI2uuvAwB2j+U1MecKQchPVC9x99+LTiHgb9tt FnmecQwPzT7XZS368Imky+JnVS7BKCGedCyIJQEGbmeGVabUGtGoeHIYZJrc5ee3TDXi ZnGQ== X-Gm-Message-State: AFqh2kqcc2HH20RiTwgbel4mDqSqVIbJdczJYz+Avz2tA3Z6KY+i1mfY JE7O6hW7pRdmwBzMsXE3k7phrzySrDkEZ7vhgbOA27OOKPqD8a9ffOyqxx905/R0Ao4uxgvyNsk dYVfoAsqv1/PTEmezXUgmWw== X-Received: by 2002:a05:622a:1a08:b0:3ab:6e0c:166b with SMTP id f8-20020a05622a1a0800b003ab6e0c166bmr4586393qtb.47.1671798137059; Fri, 23 Dec 2022 04:22:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXtuy/cAgKKIkhssIauVBEFzgx+91czS0/pNhPTxFAecy61AF1+PjIa+q0FQV4Y++aFHwlCWHg== X-Received: by 2002:a05:622a:1a08:b0:3ab:6e0c:166b with SMTP id f8-20020a05622a1a0800b003ab6e0c166bmr4586371qtb.47.1671798136823; Fri, 23 Dec 2022 04:22:16 -0800 (PST) Received: from x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id q27-20020a37f71b000000b006cec8001bf4sm2119584qkj.26.2022.12.23.04.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 04:22:15 -0800 (PST) Date: Fri, 23 Dec 2022 07:22:14 -0500 From: Brian Masney To: Johan Hovold Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, quic_shazhuss@quicinc.com, konrad.dybcio@linaro.org, robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com Subject: Re: [PATCH v3 4/7] arm64: dts: qcom: sc8280xp: add missing i2c nodes Message-ID: References: <20221220192854.521647-1-bmasney@redhat.com> <20221220192854.521647-5-bmasney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 23, 2022 at 11:37:02AM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2022 at 02:28:51PM -0500, Brian Masney wrote: > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > index f1111cd7f679..a502d4e19d98 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -813,6 +813,38 @@ qup2: geniqup@8c0000 { > > > > status = "disabled"; > > > > + i2c16: i2c@880000 { > > + compatible = "qcom,geni-i2c"; > > + reg = <0 0x00880000 0 0x4000>; > > + clocks = <&gcc GCC_QUPV3_WRAP2_S0_CLK>; > > + clock-names = "se"; > > + interrupts = ; > > + #address-cells = <1>; > > + #size-cells = <0>; > > I'm aware that the two current i2c nodes has these two properties here > in the middle, but would you mind moving '#address-cells' and > '#size-cells' after 'reg' instead where I'd expect them to be? > > Same for the spi patch. > > I can clean up the existing two nodes (and binding example) unless you > want to do it. I'll clean up the existing nodes, qcom,i2c-geni-qcom.yaml, and qcom,geni-se.yaml in my next version. Brian