From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA96C4708D for ; Mon, 26 Dec 2022 04:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbiLZEuy (ORCPT ); Sun, 25 Dec 2022 23:50:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbiLZEux (ORCPT ); Sun, 25 Dec 2022 23:50:53 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F56FE0; Sun, 25 Dec 2022 20:50:49 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B30A71EC0606; Mon, 26 Dec 2022 05:50:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672030247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=2TqhcXRdNl3g+ClAVEK77kT8OaeakGMOWOaBw6GqDn0=; b=WFP3AndyTdJ/0Y24e5xR2XhHSdoolCbSftNI2Xh2gy9QqQhv52RTizBh9Ds2KQE4EIZFn+ myKgbEhCq4N20ADJiiZGS235J4SUISmWVGrxghd/rPvAQtWzOyUG+aitPjnDjB51rdJpz0 yViGK+/U5sHd+jG7L4Z0oIyJGL1s+TQ= Date: Mon, 26 Dec 2022 05:50:42 +0100 From: Borislav Petkov To: Kun-Fa Lin Cc: krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, benjaminfair@google.com, yuenn@google.com, venture@google.com, avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, KWLIU@nuvoton.com, YSCHU@nuvoton.com, ctcchien@nuvoton.com, kflin@nuvoton.com Subject: Re: [PATCH v17 3/3] EDAC/npcm: Add NPCM memory controller driver Message-ID: References: <20221223032859.3055638-1-milkfafa@gmail.com> <20221223032859.3055638-4-milkfafa@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 26, 2022 at 11:50:54AM +0800, Kun-Fa Lin wrote: > > > + syndrome = priv->location ? 1 << priv->bit : > > > + data_synd[priv->bit]; > > > > syndrome = priv->location ? 1 << priv->bit > > : data_synd[priv->bit]; > > Just to confirm the indentation, is it right as follows? > > syndrome = priv->location ? 1 << priv->bit > : data_synd[priv->bit]; > > And I was wondering if I should just remove the line break and let it stick out? The idea is to have the '?' and the ':' under each other so that one can visually immediately "parse" where each of the sides of the ternary statement start. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette