From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947D5C4167B for ; Tue, 27 Dec 2022 21:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232450AbiL0VIS (ORCPT ); Tue, 27 Dec 2022 16:08:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbiL0VH7 (ORCPT ); Tue, 27 Dec 2022 16:07:59 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2281AC57; Tue, 27 Dec 2022 12:58:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C7870B80E8C; Tue, 27 Dec 2022 20:58:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00168C433D2; Tue, 27 Dec 2022 20:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672174718; bh=QHEGwcrBeKpSgFkBiLCph3tiMgxRBw1ycy8RzAhX6PI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AwFIma1MMVDat719aZNerCFUekEoWxXFJzPinva5LqNzBLiCWUNYwTlRK1s3IGHTs 3XR47blM/w40zCnndMiIxo1zbm8pbXn/tOwS7+gww9TvW6Oxt1isjBzC9W8EfXAN/q RGF1xD9d8fzeiuA/sJAFt1lD3ThsMJT+mluTNYrQn/ki7bHaJ333Ma3A476Wak33Tf A547kIY5lw09vFV8mj9Xa94QKyXXqxgB5o04Z46NefpNmy781p1hkFUAkRkwgl6LWa DkbPk5uPSpZL7WNGMRl7KRI5zfz4a4gOGv/lXpfMedvIT8t5tOKXAypj1F8wwpGgsM PluBSTjlKQu3Q== Date: Tue, 27 Dec 2022 20:58:32 +0000 From: Conor Dooley To: Hal Feng Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , Linus Walleij , Emil Renner Berthing , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/7] riscv: dts: starfive: Add initial StarFive JH7110 device tree Message-ID: References: <20221220011247.35560-1-hal.feng@starfivetech.com> <20221220011247.35560-7-hal.feng@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="464m7fZGrAuzw6lu" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --464m7fZGrAuzw6lu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 25, 2022 at 10:31:41PM +0800, Hal Feng wrote: > On Tue, 20 Dec 2022 21:31:43 +0000, Conor Dooley wrote: > > On Tue, Dec 20, 2022 at 09:12:46AM +0800, Hal Feng wrote: > > > From: Emil Renner Berthing > > >=20 > > > Add initial device tree for the JH7110 RISC-V SoC by StarFive > > > Technology Ltd. > > >=20 > > > Signed-off-by: Emil Renner Berthing > > > Co-developed-by: Jianlong Huang > > > Signed-off-by: Jianlong Huang > > > Co-developed-by: Hal Feng > > > Signed-off-by: Hal Feng > > > --- > > > + gpio: gpio@13040000 { > >=20 > > > + gpioa: gpio@17020000 { > >=20 > > Out of curiousity, why gpio & gpioa? >=20 > Oh, is it easier to read if I change "gpio" and "gpioa" > to "sysgpio" and "aongpio"? Thanks. I think those would be more reader friendly, that's for sure. --464m7fZGrAuzw6lu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY6tceAAKCRB4tDGHoIJi 0j1sAP9thq/K0P0uAxqb9fdxkY32mRYoo0Mkz4I81vVs0Y3poAD+OeXBv0pzKxhA 5mWXZb9nal9rZttUALcPO3BAiMtptA4= =zfRm -----END PGP SIGNATURE----- --464m7fZGrAuzw6lu--