From: Sicelo <absicsz@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
tony@atomide.com, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: n900: switch accelerometer to iio driver
Date: Wed, 28 Dec 2022 12:28:38 +0200 [thread overview]
Message-ID: <Y6waVkobLCGqRHm7@tp440p.steeds.sam> (raw)
In-Reply-To: <73599d25-cd2c-e89a-20b4-d34471583a6b@linaro.org>
Thank you for the review.
> > + lis302dl: lis302dl@1d {
>
> That's not really explained in commit msg and does not look related to
> your goal. If changing - in separate patch - make the node name generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Now I understand that it should just be `accelerometer@1d`. To be clear,
are you saying this change should have a separate patch, i.e. not part
of the switch to iio driver?
> > - Vdd-supply = <&vaux1>;
> > - Vdd_IO-supply = <&vio>;
> > + vdd-supply = <&vaux1>;
> > + vddio-supply = <&vio>;
>
> Does not look related/explained in commit msg.
This is from Documentation/devicetree/bindings/iio/st,st-sensors.yaml,
i.e. lowercase. I will look for a way to explain it in v2.
Sincerely
Sicelo
next prev parent reply other threads:[~2022-12-28 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 22:38 ARM: dts: n900: switch accelerometer to iio driver Sicelo A. Mhlongo
2022-12-27 22:38 ` [PATCH] " Sicelo A. Mhlongo
2022-12-28 9:15 ` Krzysztof Kozlowski
2022-12-28 10:28 ` Sicelo [this message]
2022-12-28 10:33 ` Krzysztof Kozlowski
2022-12-28 9:07 ` Krzysztof Kozlowski
2022-12-29 14:52 ` [PATCH v2 0/2] ARM: dts: n900: use iio driver for accelerometer Sicelo A. Mhlongo
2022-12-29 14:52 ` [PATCH v2 1/2] ARM: dts: n900: rename accelerometer node Sicelo A. Mhlongo
2022-12-29 14:59 ` Krzysztof Kozlowski
2022-12-29 14:52 ` [PATCH v2 2/2] ARM: dts: n900: use iio driver for accelerometer Sicelo A. Mhlongo
2022-12-29 15:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6waVkobLCGqRHm7@tp440p.steeds.sam \
--to=absicsz@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).