From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AEB6C4332F for ; Wed, 28 Dec 2022 22:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231243AbiL1WuA (ORCPT ); Wed, 28 Dec 2022 17:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiL1Wt7 (ORCPT ); Wed, 28 Dec 2022 17:49:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08AC4140E9; Wed, 28 Dec 2022 14:49:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A184861635; Wed, 28 Dec 2022 22:49:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 903F4C433EF; Wed, 28 Dec 2022 22:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672267798; bh=eKpTMGHSO/ZTiq4eGqbwHQljT2nRfrSmDBVcf8nJCYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZXpJJnxOYfx1zvBUjyx9GEH+2hTVRek2WMdMyP+RQl8OiGWzkwrq5GdTM82ZFyS6e fzVLwa0jK6yhYivq7y4tsnxPKJ9G3FevsX2ZhoyBgeAXEfmkKA67V0839PmTKAUXHC 0AzKeJnExpNBUHdLjcscNXvKSzoSAERPh8vb//oHp3h335yAshQz5+kq3enT1GTTfq aKYlPOOn8EGC8XQ570ilGBn1FVE0KxLoOLPOZN6S7YFtNrPmb4Tnrw4Gnm56qWIVRb NMdTtg07SzUo+xkOWdDthrDKohLeUS7IHPlXnl+ozdVtRAvzm92EIZ2RZkg0ZNEHzo R1viICb+35LbA== Date: Wed, 28 Dec 2022 22:49:52 +0000 From: Conor Dooley To: Hal Feng Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , Linus Walleij , Emil Renner Berthing , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 7/7] riscv: dts: starfive: Add StarFive JH7110 VisionFive 2 board device tree Message-ID: References: <20221220011247.35560-1-hal.feng@starfivetech.com> <20221220011247.35560-8-hal.feng@starfivetech.com> <94c90f3f-0ca7-7cfb-4d4f-8f90e3300e16@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0TJGFiimdGLWYNPZ" Content-Disposition: inline In-Reply-To: <94c90f3f-0ca7-7cfb-4d4f-8f90e3300e16@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --0TJGFiimdGLWYNPZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 23, 2022 at 11:12:34AM +0800, Hal Feng wrote: > On Tue, 20 Dec 2022 21:26:07 +0000, Conor Dooley wrote: > > On Tue, Dec 20, 2022 at 09:12:47AM +0800, Hal Feng wrote: > > > From: Emil Renner Berthing > > >=20 > > > Add a minimal device tree for StarFive JH7110 VisionFive 2 board > > > which has version A and version B. Support booting and basic > > > clock/reset/pinctrl/uart drivers. > > >=20 > > > Signed-off-by: Emil Renner Berthing > > > Co-developed-by: Jianlong Huang > > > Signed-off-by: Jianlong Huang > > > Co-developed-by: Hal Feng > > > Signed-off-by: Hal Feng > > > --- > > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-= 2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > > > new file mode 100644 > > > index 000000000000..c60280b89c73 > > > --- /dev/null > > > +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > > > @@ -0,0 +1,111 @@ > > > +// SPDX-License-Identifier: GPL-2.0 OR MIT > > > +/* > > > + * Copyright (C) 2022 StarFive Technology Co., Ltd. > > > + * Copyright (C) 2022 Emil Renner Berthing > > > + */ > > > + > > > +/dts-v1/; > > > +#include "jh7110.dtsi" > > > +#include "jh7110-pinfunc.h" > > > +#include > > > + > > > +/ { > > > + aliases { > > > + serial0 =3D &uart0; > > > + }; > > > + > > > + chosen { > > > + stdout-path =3D "serial0:115200n8"; > > > + }; > > > + > > > + cpus { > > > + timebase-frequency =3D <4000000>; > > > + }; > > > + > > > + memory@40000000 { > > > + device_type =3D "memory"; > > > + reg =3D <0x0 0x40000000 0x1 0x0>; > >=20 > > Is this a good idea when you have SKUs with 2, 4 & 8 GiB of DDR? >=20 > The VisionFive 2 board only has 4GB version and 8GB version now. Before > linux startup, we will change this property in dtb through u-boot to > make sure the board can boot up with the correct memory size. Ah I see. Thanks. --0TJGFiimdGLWYNPZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY6zIDwAKCRB4tDGHoIJi 0gMNAQCvOfHtZr3PoXFX2+mCzgr6JsCjRiW7PbUqOVqUw8b9dgD/clvylp+cEFHt ztVMWXpjCLcWCFgDniZe/S3nBDLNmQA= =tziJ -----END PGP SIGNATURE----- --0TJGFiimdGLWYNPZ--