From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: Rob Herring <robh@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Xu Liang <lxu@maxlinear.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings
Date: Wed, 11 Jan 2023 23:48:01 +0100 [thread overview]
Message-ID: <Y788oSXbsqmAMVxw@lunn.ch> (raw)
In-Reply-To: <73f8aad30e0d5c3badbd62030e545ef6@walle.cc>
> I know, I noticed this the first time I tested the schema. But then
> I've looked at all the other PHY binding and not one has a compatible.
>
> I presume if there is a compatible, the devicetrees also need a
> compatible. So basically, "required: compatible" in the schema, right?
> But that is where the PHY maintainers don't agree.
It should not be required. The compatible is optional. The kernel is
happy without it. You can add a compatible to make the DT linter
happy, but you are only adding it to make the linter work. Hence it
needs to be optional. All real DT blobs are unlikely to have a
compatible, given that this PHY is known not to be broken in terms of
enumeration via its ID registers.
Andrew
next prev parent reply other threads:[~2023-01-11 22:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 12:30 [PATCH net-next v3 0/4] net: phy: mxl-gpy: broken interrupt fixes Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 1/4] dt-bindings: vendor-prefixes: add MaxLinear Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 2/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings Michael Walle
2023-01-09 13:39 ` Andrew Lunn
2023-01-11 20:26 ` Rob Herring
2023-01-11 21:24 ` Andrew Lunn
2023-01-11 22:30 ` Michael Walle
2023-01-11 22:48 ` Andrew Lunn [this message]
2023-01-13 16:38 ` Rob Herring
2023-01-13 21:48 ` Michael Walle
2023-01-09 12:30 ` [PATCH net-next v3 3/4] net: phy: allow a phy to opt-out of interrupt handling Michael Walle
2023-01-09 13:40 ` Andrew Lunn
2023-01-09 12:30 ` [PATCH net-next v3 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default Michael Walle
2023-01-09 13:41 ` Andrew Lunn
2023-01-10 13:10 ` [PATCH net-next v3 0/4] net: phy: mxl-gpy: broken interrupt fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y788oSXbsqmAMVxw@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).