From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CDD2C5479D for ; Fri, 6 Jan 2023 09:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233116AbjAFJjz (ORCPT ); Fri, 6 Jan 2023 04:39:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231858AbjAFJj3 (ORCPT ); Fri, 6 Jan 2023 04:39:29 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0939B45677; Fri, 6 Jan 2023 01:31:25 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D20AF4AE; Fri, 6 Jan 2023 10:31:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1672997483; bh=eW6rNAgrifU2DzhpvGHPC3nUtWhamr7BoiOuA6FOSCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZFl1mgDgQ8pHrE9GH22/oiZkYb3/qnURlpqCOHCKiuu2Sq0r127f18aViEu+h38Oj 3mk5kkOf9yzxdOJQD45iqjoLnbhdcykvv5ok7HUGL2gYVuP7Us1VfJSIYIkwjBuVOW Osty2MM9tFaUqM23ZEifJfq5WwJWyNnN7R7d7Ap8= Date: Fri, 6 Jan 2023 11:31:17 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: Nicholas Roth , Robert Mader , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Jacopo Mondi , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: media: Add schema for OmniVision OV8858 Message-ID: References: <20230105172320.133810-1-jacopo@jmondi.org> <20230105172320.133810-2-jacopo@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230105172320.133810-2-jacopo@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jacopo, Thank you for the patch. One comment in addition to Krzysztof's. On Thu, Jan 05, 2023 at 06:23:19PM +0100, Jacopo Mondi wrote: > From: Jacopo Mondi > > Add binding schema for the OmniVision OV8858 8 Megapixels camera sensor. > > Signed-off-by: Jacopo Mondi > --- > .../bindings/media/i2c/ovti,ov8858.yaml | 109 ++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml > new file mode 100644 > index 000000000000..f6d5cf69234c > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov8858.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: OmniVision OV8858 Image Sensor > + > +maintainers: > + - Jacopo Mondi > + - Nicholas Roth > + > +description: | > + The OmniVision OV8858 is a color CMOS 8 Megapixles (3264x2448) image sensor s/pixles/pixels/ Conditionally-Reviewed-by: Laurent Pinchart with this and the issues pointed by Krzysztof first. > + controlled through an I2C-compatible SCCB bus. The sensor transmits images > + on a MIPI CSI-2 output interface with up to 4 data lanes. > + > +properties: > + compatible: > + const: ovti,ov8858 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: XVCLK external clock > + > + clock-names: > + const: xvclk > + > + dvdd-supply: > + description: Digital Domain Power Supply > + > + avdd-supply: > + description: Analog Domain Power Supply > + > + dovdd-supply: > + description: I/O Domain Power Supply > + > + powerdown-gpios: > + maxItems: 1 > + description: PWDNB powerdown GPIO (active low) > + > + reset-gpios: > + maxItems: 1 > + description: XSHUTDN reset GPIO (active low) > + > + port: > + description: MIPI CSI-2 transmitter port > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + minItems: 1 > + maxItems: 4 > + > + required: > + - data-lanes > + > +required: > + - compatible > + - reg > + - clocks > + - assigned-clocks > + - assigned-clock-rates > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + i2c2 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ov8858: camera@36 { > + compatible = "ovti,ov8858"; > + reg = <0x36>; > + > + clocks = <&cru SCLK_CIF_OUT>; > + clock-names = "xvclk"; > + assigned-clocks = <&cru SCLK_CIF_OUT>; > + assigned-clock-rates = <24000000>; > + > + dovdd-supply = <&vcc1v8_dvp>; > + > + reset-gpios = <&gpio1 RK_PA4 GPIO_ACTIVE_LOW>; > + powerdown-gpios = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>; > + > + port { > + ucam_out: endpoint { > + remote-endpoint = <&mipi_in_ucam>; > + data-lanes = <1 2 3 4>; > + }; > + }; > + }; > + }; > +... -- Regards, Laurent Pinchart