From: Andrew Lunn <andrew@lunn.ch>
To: "Frank.Sae" <Frank.Sae@motor-comm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
xiaogang.fan@motor-comm.com, fei.zhang@motor-comm.com,
hua.sun@motor-comm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/3] dt-bindings: net: Add Motorcomm yt8xxx ethernet phy Driver bindings
Date: Fri, 6 Jan 2023 14:58:20 +0100 [thread overview]
Message-ID: <Y7go/KP8TZTdp6wm@lunn.ch> (raw)
In-Reply-To: <8fa89dac-6859-af93-0dc0-ffcb42b5bb30@motor-comm.com>
> >> + motorcomm,rx-delay-basic:
> >> + description: |
> >> + Tristate, setup the basic RGMII RX Clock delay of PHY.
> >> + This basic delay is fixed at 2ns (1000Mbps) or 8ns (100Mbps、10Mbps).
> >> + This basic delay usually auto set by hardware according to the voltage
> >> + of RXD0 pin (low = 0, turn off; high = 1, turn on).
> >> + If not exist, this delay is controlled by hardware.
> >
> > I don't understand that at all. What "not exist"? There is no verb and
> > no subject.
> >
> > The type and description are really unclear.
> >
> >> + 0: turn off; 1: turn on.
> >> + $ref: /schemas/types.yaml#/definitions/uint32
> >> + enum: [0, 1]
> >
> > So this is bool?
> >
>
> This basic delay can be controlled by hardware or dts.
>
> Default value depends on power on strapping, according to the voltage
> of RXD0 pin (low = 0, turn off; high = 1, turn on).
>
> "not exist" means that This basic delay is controlled by hardware,
> and software don't change this.
As i said in my other reply, this is not how Linux controls this. This
property should be removed.
Andrew
next prev parent reply other threads:[~2023-01-06 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 7:30 [PATCH net-next v1 0/3] add dts for yt8521 and yt8531s, add driver for yt8531 Frank
2023-01-05 7:30 ` [PATCH net-next v1 1/3] dt-bindings: net: Add Motorcomm yt8xxx ethernet phy Driver bindings Frank
2023-01-05 13:17 ` Andrew Lunn
2023-01-06 6:51 ` Frank
2023-01-06 13:55 ` Andrew Lunn
2023-01-11 9:20 ` Frank.Sae
2023-01-11 13:07 ` Andrew Lunn
2023-01-16 2:49 ` Frank.Sae
[not found] ` <9b047a2a-ccd8-6079-efbf-5cb880bf5044@starfivetech.com>
2023-01-17 13:16 ` Andrew Lunn
2023-01-18 13:40 ` Andrew Lunn
2023-01-19 5:56 ` Frank.Sae
2023-01-06 8:26 ` Krzysztof Kozlowski
2023-01-06 9:17 ` Frank.Sae
2023-01-06 9:25 ` Krzysztof Kozlowski
2023-01-06 13:58 ` Andrew Lunn [this message]
2023-01-05 7:30 ` [PATCH net-next v1 2/3] net: phy: Add dts support for Motorcomm yt8521/yt8531s gigabit ethernet phy Frank
2023-01-05 9:01 ` Arun.Ramadoss
2023-01-06 5:24 ` Frank
2023-01-05 17:03 ` Andrew Lunn
2023-01-06 7:42 ` Frank.Sae
2023-01-06 13:32 ` Andrew Lunn
2023-01-05 7:30 ` [PATCH net-next v1 3/3] net: phy: Add driver for Motorcomm yt8531 " Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7go/KP8TZTdp6wm@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fei.zhang@motor-comm.com \
--cc=hkallweit1@gmail.com \
--cc=hua.sun@motor-comm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=xiaogang.fan@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).