From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99204C54EBE for ; Mon, 9 Jan 2023 11:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbjAILFR (ORCPT ); Mon, 9 Jan 2023 06:05:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237184AbjAILE4 (ORCPT ); Mon, 9 Jan 2023 06:04:56 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85AD015FC4 for ; Mon, 9 Jan 2023 03:04:55 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id vm8so19108484ejc.2 for ; Mon, 09 Jan 2023 03:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tv4unt6g/AUf+t5glAMtGuBCzixTzpJWSEQGM4BGflY=; b=VQx2zAlL8kN6uG+7JWYEJoITY9l4pHtMCOnQx8CPY/og4NlmE+j1FYm7qnBALMJSN4 e+SPSYfTzK+mKzP/0W9y9d580v+9fJx4ylZmmDc9Ak+sjWCIjmWTmJThOIxdW0iVjnPb 6AbXKo3ebSBdHJszF8W2KkL65tqVZ9Boy7O3qVBNjqwhZevA991TFA/bWzFDkDYE8+s5 Ug9ognRPLeYX1u9Qdd82CZgu4iFED8K3opd8GmBW6PanaAz+kLQUW8fRYzX55SQUT7Vn ITRSfewIzMvY7pUh7zQ/Gjv4JJ1VueMc1ye6ilnDAyPCTZLB5GbqBXQEM5TLi9du+jT+ SZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tv4unt6g/AUf+t5glAMtGuBCzixTzpJWSEQGM4BGflY=; b=VSK+F5iEhmUkitU31aKab8TZIUR74u8eNwdC8Xbwq1nHqDkLX+STGSjlthc/ZAFKP+ Ck2a1M9Jv7LDCkPlYsLfpj7fbyOiHEO7B1slUj/aBttem/DSglIJjAt6fk1SxX+wzh8n pQiLeW4Od8o8Ha4nU6EjFGPl+NdxvDWLyAgk+ZFJqZBxRkvrnOb9ibkxssOSyVko+kVt zgCiYERvQ/p2iXUIslUc4glGL5iWpd/JJmcrnr6Kq1z557/MxfmpNUgHLDXt28X4gMBR aX/H6x9UkbJu5b4FAX4HSDcuwGj3sZPZwFWFBE89jfxFBJoNTAmsPkV7aT9jJdTJIMI9 vR2Q== X-Gm-Message-State: AFqh2koO+Pj1dQxr6ZAmtNhsFJZTteafbmo2OZOp0TB5cJrs2T0ZqMZF 5dd0hyBvYIlsxt1P8IKQ3edfYA== X-Google-Smtp-Source: AMrXdXv5Toeyv23qi+jF5SyuM7XY19FOEceyiyCUGuFHt8aKOmJpRZUFfHJ6di+BUYbHPfDz1mn29A== X-Received: by 2002:a17:906:f13:b0:7b2:7a42:3e43 with SMTP id z19-20020a1709060f1300b007b27a423e43mr52579788eji.23.1673262294124; Mon, 09 Jan 2023 03:04:54 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id o21-20020aa7c7d5000000b0046ac017b007sm3525171eds.18.2023.01.09.03.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:04:53 -0800 (PST) Date: Mon, 9 Jan 2023 13:04:52 +0200 From: Abel Vesa To: Stephen Boyd Cc: Jun Li , abelvesa@kernel.org, "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "mturquette@baylibre.com" , "l.stach@pengutronix.de" , Peng Fan , "alexander.stein@ew.tq-group.com" , "gregkh@linuxfoundation.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend clk Message-ID: References: <1664549663-20364-1-git-send-email-jun.li@nxp.com> <1664549663-20364-2-git-send-email-jun.li@nxp.com> <20221027173919.12E23C433C1@smtp.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23-01-09 12:52:17, Abel Vesa wrote: > On 22-10-27 10:39:16, Stephen Boyd wrote: > > Quoting Jun Li (2022-10-19 02:26:00) > > > Hi Stephen, > > > > > > > -----Original Message----- > > > > From: Jun Li > > > > Sent: Friday, September 30, 2022 10:54 PM > > > > To: sboyd@kernel.org; abelvesa@kernel.org > > > > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > > > > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > > > > festevam@gmail.com; dl-linux-imx ; > > > > mturquette@baylibre.com; l.stach@pengutronix.de; Peng Fan > > > > ; alexander.stein@ew.tq-group.com; > > > > gregkh@linuxfoundation.org; devicetree@vger.kernel.org; > > > > linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org > > > > Subject: [PATCH v4 2/3] clk: imx: imx8mp: add shared clk gate for usb suspend > > > > clk > > > > > > > > 32K usb suspend clock gate is shared with usb_root_clk, this shared clock > > > > gate was initially defined only for usb suspend clock, usb suspend clk is > > > > kept on while system is active or system sleep with usb wakeup enabled, so > > > > usb root clock is fine with this situation; with the commit cf7f3f4fa9e5 > > > > ("clk: imx8mp: fix usb_root_clk parent"), this clock gate is changed to be > > > > for usb root clock, but usb root clock will be off while usb is suspended, > > > > so usb suspend clock will be gated too, this cause some usb functionalities > > > > will not work, so define this clock to be a shared clock gate to conform > > > > with the real HW status. > > > > > > > > Fixes: 9c140d9926761 ("clk: imx: Add support for i.MX8MP clock driver") > > > > Cc: stable@vger.kernel.org # v5.19+ > > > > Tested-by: Alexander Stein > > > > Signed-off-by: Li Jun > > > > > > Is this version okay for you? > > > > > > > I thought that Abel was going to pick these up. > > Oh, sorry, I thought the fixes will be picked up by you. > > I'll apply it to my tree then. Ugrh, ignore this. Already applied. My inbox is messed up a bit right now. Sorry about that.