From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CF4C5479D for ; Mon, 9 Jan 2023 13:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjAINzx (ORCPT ); Mon, 9 Jan 2023 08:55:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234914AbjAINzt (ORCPT ); Mon, 9 Jan 2023 08:55:49 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00B9E34D47; Mon, 9 Jan 2023 05:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673272547; x=1704808547; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tGKHnAfBxD0cWgsYK90ScVvKbs945zzAa+okIcBUQCc=; b=WWn4ZPbIkg1X8LY0za3SWAx7qSnt0cyB2yGtOkR2byIMalWPiLABAlzN 0ENz9NPxFHOgBIz97dtt4wHCAn/CfJ7jOrI0wLsBTSCLhEEwR2LyQETSv dZDFyXV8nQfDCCHoPAtkJquEJ66vy/C77qerLA5uf+MnStSrt65F8lzzY iyd8uyGsQa8IaR8uvdQtgMvCIXy0wWnAZHa+vhbOqVMbB443R6u5CKHgQ MPLnMFQgHestzjFt6PkCxiGwYdhpgCRKt+wSZznVJmoeCTA8VA27rBZbL 8Motu+oP15oXn1Pv8zUNimmNxRZ8Qxa+Yqa3SKA9hV7qWBArz4PdokplP g==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="409118980" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="409118980" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 05:55:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="799032829" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="799032829" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 09 Jan 2023 05:55:42 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pEscl-006VQL-0l; Mon, 09 Jan 2023 15:55:39 +0200 Date: Mon, 9 Jan 2023 15:55:38 +0200 From: Andy Shevchenko To: Tomi Valkeinen Cc: Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Wolfram Sang , Luca Ceresoli , Matti Vaittinen , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Sakari Ailus , Michael Tretter , Shawn Tu , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut Subject: Re: [PATCH v6 7/8] media: i2c: add DS90UB913 driver Message-ID: References: <20230105140307.272052-1-tomi.valkeinen@ideasonboard.com> <20230105140307.272052-8-tomi.valkeinen@ideasonboard.com> <5173a16a-83c5-5cfe-f6ce-03e1c90e8790@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5173a16a-83c5-5cfe-f6ce-03e1c90e8790@ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 09, 2023 at 02:59:01PM +0200, Tomi Valkeinen wrote: > On 09/01/2023 13:07, Andy Shevchenko wrote: > > On Sun, Jan 08, 2023 at 06:06:34AM +0200, Laurent Pinchart wrote: > > > On Thu, Jan 05, 2023 at 04:03:06PM +0200, Tomi Valkeinen wrote: ... > > > > + gc->of_node = priv->client->dev.of_node; > > > > We don't have of_node anymore in gc. And if the parent device is set, you can > > drop this line (it will work with older and newer kernels. Otherwise, use > > fwnode. > > What do you mean "we don't have of_node anymore"? There is no of_node member of struct gpio_chip anymore. This will fail to compile. -- With Best Regards, Andy Shevchenko