From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>,
linux-rtc@vger.kernel.org, linux-mips@vger.kernel.org,
loongarch@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, Qing Zhang <zhangqing@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
zhaoxiao <zhaoxiao@uniontech.com>
Subject: Re: [PATCH V2 0/7] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC
Date: Tue, 24 Jan 2023 00:15:45 +0100 [thread overview]
Message-ID: <Y88VIXerF5Wk/9kj@mail.local> (raw)
In-Reply-To: <cover.1673227292.git.zhoubinbin@loongson.cn>
On 09/01/2023 09:35:10+0800, Binbin Zhou wrote:
> Hi all:
>
> The initial DT-base ls2x rtc driver was written by Wang Xuerui, He has
> released five versions of patchset before, and all related mail records
> are shown below if you are interested:
>
> https://lore.kernel.org/all/?q=ls2x-rtc
>
> In this series of patches, based on the code above, I have added the
> following support:
>
> 1. Add ACPI-related support, as Loongson-3A5000 + LS7A is now ACPI-base
> by default under LoongArch architecture;
> 2. Add rtc alarm/walarm related functions.
>
> I have tested on Loongson-3A5000LA+LS7A1000/LS7A2000, Loongson-2K1000LA
> and Loongson-2K0500.
>
> BTW:
> There have been discussions about merging the rtc drivers of ls1x and
> ls2x, but the following reasons made the merger difficult to achieve:
>
> 1. ls1x does not support ACPI, for it is only on MIPS-based system;
This is not a good justification, you have to support both in your
driver anyway, as shown by your CONFIG_ACPI ifdefery.
> 2. ls1x does not support alarm function.
It is just a matter of clearing a single bit, this is not difficult at
all.
>
> Thanks.
>
> -------
> Changes since v1:
> 1. Rebased on top of latest loongarch-next;
> 2. Add interrupt descriptions to the ls2k and ls7a DTS files to avoid
> errors when the driver gets the IRQ number, Thanks to Qing Zhang for
> testing;
> 3. Remove some inexact CONFIG_ACPI.
>
> Binbin Zhou (4):
> rtc: Add support for the Loongson-2K/LS7A RTC
> LoongArch: Enable LS2X RTC in loongson3_defconfig
> MIPS: Loongson64: DTS: Add RTC support to LS7A
> MIPS: Loongson64: DTS: Add RTC support to Loongson-2K
>
> WANG Xuerui (3):
> dt-bindings: rtc: Add Loongson LS2X RTC support
> MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig
> MIPS: Loongson: Enable LS2X RTC in loongson2k_defconfig
>
> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 +
> arch/loongarch/configs/loongson3_defconfig | 1 +
> .../boot/dts/loongson/loongson64-2k1000.dtsi | 7 +
> arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 7 +
> arch/mips/configs/loongson2k_defconfig | 1 +
> arch/mips/configs/loongson3_defconfig | 1 +
> drivers/rtc/Kconfig | 11 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-ls2x.c | 379 ++++++++++++++++++
> 9 files changed, 410 insertions(+)
> create mode 100644 drivers/rtc/rtc-ls2x.c
>
> --
> 2.31.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-01-23 23:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 1:35 [PATCH V2 0/7] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC Binbin Zhou
2023-01-09 1:35 ` [PATCH V2 1/7] dt-bindings: rtc: Add Loongson LS2X RTC support Binbin Zhou
2023-01-09 1:35 ` [PATCH V2 2/7] rtc: Add support for the Loongson-2K/LS7A RTC Binbin Zhou
2023-01-11 16:48 ` Jiaxun Yang
2023-01-23 23:34 ` Alexandre Belloni
2023-02-01 9:16 ` Binbin Zhou
2023-02-14 23:13 ` Alexandre Belloni
2023-02-27 2:26 ` Binbin Zhou
2023-02-27 5:39 ` Alexandre Belloni
2023-01-09 1:35 ` [PATCH V2 3/7] LoongArch: Enable LS2X RTC in loongson3_defconfig Binbin Zhou
2023-01-09 1:36 ` [PATCH V2 4/7] MIPS: Loongson64: DTS: Add RTC support to LS7A Binbin Zhou
2023-01-09 1:36 ` [PATCH V2 5/7] MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig Binbin Zhou
2023-01-09 1:36 ` [PATCH V2 6/7] MIPS: Loongson64: DTS: Add RTC support to Loongson-2K Binbin Zhou
2023-01-11 16:47 ` Jiaxun Yang
2023-01-09 1:36 ` [PATCH V2 7/7] MIPS: Loongson: Enable LS2X RTC in loongson2k_defconfig Binbin Zhou
2023-01-23 23:15 ` Alexandre Belloni [this message]
2023-01-31 12:59 ` [PATCH V2 0/7] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC Binbin Zhou
2023-02-10 10:03 ` Binbin Zhou
2023-02-14 23:17 ` Alexandre Belloni
2023-02-15 2:16 ` Kelvin Cheung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y88VIXerF5Wk/9kj@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
--cc=zhangqing@loongson.cn \
--cc=zhaoxiao@uniontech.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).