From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163A5C54EBC for ; Thu, 12 Jan 2023 15:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjALP7c (ORCPT ); Thu, 12 Jan 2023 10:59:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbjALP7A (ORCPT ); Thu, 12 Jan 2023 10:59:00 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43194261A; Thu, 12 Jan 2023 07:49:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 201EFCE1E7B; Thu, 12 Jan 2023 15:49:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F747C433A0; Thu, 12 Jan 2023 15:49:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673538566; bh=sF0ezM+HFkfL1CfTp3012TuYafZ/7llu2ivf2JNXegI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kiWi/GUIFZo7uni7Zr3NCtMMcqukssB81CDpPXmoVSWLISF9CN1qGu+Upf+jYnhmz aUlS+rduvno03ku/ybeTbypVRl81wbCkCgtCbc1q1v2Ce3B7NQA3IphSEwz1GH4acR IqUXB8yyRCQ1822i1KT6MbGsfm4bdGDLQ0g6PLalwnaYcePcxKZllotWuVE3TvPeA7 vL7+sBG4pzmqCevS5hP6bv6rvwyB8u69c9iyxeuyR4ng9ULPm9z+Aidyq33j9aTIDi MrkGPw1ujeB+w8LE8CzyHgNEtO9zWwrhZT8aT/vsrEB14A0O7tGQ6FLjFHvIOToXFh TVG7x8KFBTLrQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pFzpd-0002WT-TH; Thu, 12 Jan 2023 16:49:33 +0100 Date: Thu, 12 Jan 2023 16:49:33 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Vote for CX in USB controllers Message-ID: References: <20230112135117.3836655-1-quic_bjorande@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112135117.3836655-1-quic_bjorande@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jan 12, 2023 at 05:51:17AM -0800, Bjorn Andersson wrote: > Running GCC_USB30_*_MASTER_CLK at 200MHz requires CX at nominal level, > not doing so results in occasional lockups. This was previously hidden > by the fact that the display stack incorrectly voted for CX (instead of > MMCX). > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 2ed17baf50d3..4f4353f84cba 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -2265,6 +2265,7 @@ usb_0: usb@a6f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_PRIM_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > @@ -2319,6 +2320,7 @@ usb_1: usb@a8f8800 { > "ss_phy_irq"; > > power-domains = <&gcc USB30_SEC_GDSC>; > + required-opps = <&rpmhpd_opp_nom>; > > resets = <&gcc GCC_USB30_SEC_BCR>; Looks good. Perhaps you can send a binding patch adding 'required-oops' as well. Reviewed-by: Johan Hovold Johan