Re: [PATCH v3 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC

Conor Dooley
2023-01-31T13:26:02Z

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

On Tue, Jan 31, 2023 at 02:13:44PM +0100, Linus Walleij wrote:
> On Tue, Dec 20, 2022 at 1:55 AM Hal Feng <hal.feng@starfivetech.com> wrote:
>
> > This patch series adds basic pinctrl support for StarFive JH7110 SoC.
> > You can simply get or review the patches at the link [1].
> >
> > [1]: https://github.com/hal-feng/linux/commits/visionfive2-minimal
> >
> > Changes since v2:
> > - Rebased on tag v6.1.
>
> Overall this looks OK, the DT bindings does not have any review from
> the DT people but I think they had enough time to do that and were
> properly CC:ed so not your fault.

FWIW, Rob left comments on patches 2 & 3 of the series:
https://lore.kernel.org/linux-riscv/20221220201920.GA1012864-robh@kernel.org/
https://lore.kernel.org/linux-riscv/20221220202003.GA1018798-robh@kernel.org

Relatively minor, but not ignored by the DT people.

> However when I try to apply this to the pinctrl tree it fails,
> for example it seems to depend on an entry in MAINTAINERS
> which isn't upstream.
>
> Can you please rebase the patches that are supposed to be
> applied to the pinctrl tree (for example normally not patch 1, the DTS
> patch) on my "devel" branch:

Yah, the DTS patch needs to be dropped, the file it applies to doesn't
exist in any branch yet.

> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
>
> If you resend this quickly I can apply it pronto.

It'd be nice to get this stuff into v6.3 if there is still time so that
there is one thing fewer blocking the base platform support!

Thanks Linus,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]