From: Dan Carpenter <error27@gmail.com>
To: Doug Brown <doug@schmorgal.com>
Cc: oe-kbuild@lists.linux.dev, Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 5/8] mmc: sdhci-pxav2: add optional core clock
Date: Mon, 16 Jan 2023 12:02:56 +0300 [thread overview]
Message-ID: <Y8USwHNZfuaP1ro8@kadam> (raw)
In-Reply-To: <b5867cb5-aeed-b081-543f-fd611c3c84c9@schmorgal.com>
On Sat, Jan 14, 2023 at 02:49:07PM -0800, Doug Brown wrote:
> Hi Dan,
>
> On 1/14/2023 12:01 AM, Dan Carpenter wrote:
> > Hi Doug,
> >
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> >
> > url: https://github.com/intel-lab-lkp/linux/commits/Doug-Brown/mmc-sdhci-pxav2-add-initial-support-for-PXA168-V1-controller/20230112-102921
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> > patch link: https://lore.kernel.org/r/20230112022416.8474-6-doug%40schmorgal.com
> > patch subject: [PATCH v4 5/8] mmc: sdhci-pxav2: add optional core clock
> > config: riscv-randconfig-m041-20230113
> > compiler: riscv64-linux-gcc (GCC) 12.1.0
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Reported-by: Dan Carpenter <error27@gmail.com>
> >
> > smatch warnings:
> > drivers/mmc/host/sdhci-pxav2.c:220 sdhci_pxav2_probe() warn: missing error code 'ret'
>
> Thanks for passing this on. I definitely forgot an assignment to ret.
> Since this is correcting an error in my patch that hasn't been accepted
> yet, is it safe to assume I should omit those Reported-by tags from the
> next version of my patch, since they don't apply to the patch itself?
>
These emails are from the kbuild team and not from me. I just look them
over and hit the forward button. I'm sure it helps the kbuild team in
their marketing when people use the tags... Right now I'm applying to
jobs outside the Linux community so the tags give me a measurable thing
to say I've helped fix thousands of bugs or whatever...
I've always argued that there should be a different Fixes-from: tag for
people who find bugs during review (as opposed to just complaining about
white space which is its own reward and I do that for free). So far I
haven't convinced anyone on this though.
Anyway, there isn't a policy one way or the other. Some people add
them and some don't. Some people add them below the --- cut off line,
but I don't know if that's deliberate or what the story is there. That
seems like it might be a good compromise.
regards,
dan carpenter
next prev parent reply other threads:[~2023-01-16 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 2:24 [PATCH v4 0/8] mmc: sdhci-pxav2: Add support for PXA168 Doug Brown
2023-01-12 2:24 ` [PATCH v4 1/8] mmc: sdhci-pxav2: add initial support for PXA168 V1 controller Doug Brown
2023-01-12 2:24 ` [PATCH v4 2/8] mmc: sdhci-pxav2: enable CONFIG_MMC_SDHCI_IO_ACCESSORS Doug Brown
2023-01-12 2:24 ` [PATCH v4 3/8] mmc: sdhci-pxav2: add register workaround for PXA168 silicon bug Doug Brown
2023-01-12 2:24 ` [PATCH v4 4/8] mmc: sdhci-pxav2: change clock name to match DT bindings Doug Brown
2023-01-12 2:24 ` [PATCH v4 5/8] mmc: sdhci-pxav2: add optional core clock Doug Brown
2023-01-14 8:01 ` Dan Carpenter
2023-01-14 22:49 ` Doug Brown
2023-01-16 9:02 ` Dan Carpenter [this message]
2023-01-16 9:07 ` Krzysztof Kozlowski
2023-01-16 19:06 ` Doug Brown
2023-01-12 2:24 ` [PATCH v4 6/8] mmc: sdhci-pxav2: add SDIO card IRQ workaround for PXA168 V1 controller Doug Brown
2023-01-12 2:24 ` [PATCH v4 7/8] mmc: sdhci-pxav2: add optional pinctrl for SDIO IRQ workaround Doug Brown
2023-01-12 2:24 ` [PATCH v4 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1 Doug Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8USwHNZfuaP1ro8@kadam \
--to=error27@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=doug@schmorgal.com \
--cc=krzk@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).