From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A217CC54EBE for ; Mon, 16 Jan 2023 14:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230076AbjAPOvn (ORCPT ); Mon, 16 Jan 2023 09:51:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbjAPOvX (ORCPT ); Mon, 16 Jan 2023 09:51:23 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7D061D92C for ; Mon, 16 Jan 2023 06:36:03 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id x10so38081584edd.10 for ; Mon, 16 Jan 2023 06:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rCZPqWPiwmy+Qg3w9Zw0kU442c7Jihjgka7OZcZFvZ4=; b=vK/m3ZhBu0rXmwlaHWgHg/SJV3wZwAcbhd6qMxLW6BfEHoQz0LWh1fbCr8C+lK5HmS bhRZ1X9ylmKvKawQ3N6yph8My2pmJvfm0eafkOElbuheYZVdMhjGMwR8YExcCfbR/kL8 7eeGDkBW4uSNo0sICPIofDBbdeMdir6P4y2J0LpZl3rAU4eXG4k6SY8gQa6LsLjo1Hyd UJgJqfqxKJJnyqeIXL8PxL4bMoBZkHOqmADuqiClaUMVQQH1XIk5czTyl31+GkSEqVyO b/3x0jhIpJSBAntgZfJ52P3wbP7zLAnGw9xJE+2x3+hDg8AAW3SluiWijSVism0Kxc2q uc/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rCZPqWPiwmy+Qg3w9Zw0kU442c7Jihjgka7OZcZFvZ4=; b=naivcjMhtDaB+zTtpu9wBtRIDDqar14DB5kKcDcC/nxDtm8wIAC6IlE1FhqUck/4cU J43mZeSFcRJsA75kOttvhVbA2TIBm1L0mKl+i2uNpDzXv66HLnzi2pB4xKbiqvsWW7g3 I354/M5ywNXjGtbmZSY7evQPknWNTxbKapbY5P/tsqhHnt17t5y/5mMi7TpozfXBFyjE TvADmAbEROfbFkFNGzvvKFFx/YiZgVkdeTHFXj2xwDLbuSnKjLoW1uxpZJhSdx20on+d iAM1IRZh7OxoAjIiIPL496r5kreeqAsLFIIkxVT69PDAQcwcjNF8pmVmBTLE5eH0PuN5 6JYg== X-Gm-Message-State: AFqh2kowmBt19+sP1N/fxSWUS2TQ+RkZ7LrlKvuq85PKFQWwhvu6OA27 6PvluS/5zDOaXKOqtdOVnaUaQA== X-Google-Smtp-Source: AMrXdXtV7SF+3RSBX9E7TN51Zz8RFwX6gb7hQ8yrCuB589NuTrrLEfdLDjrguaEyTdVgTYDRIpbTRw== X-Received: by 2002:a05:6402:2a02:b0:470:44eb:9e58 with SMTP id ey2-20020a0564022a0200b0047044eb9e58mr82109589edb.30.1673879762167; Mon, 16 Jan 2023 06:36:02 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id d3-20020aa7d5c3000000b004835bd8dfe5sm11665624eds.35.2023.01.16.06.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:36:01 -0800 (PST) Date: Mon, 16 Jan 2023 16:35:59 +0200 From: Abel Vesa To: Dario Binacchi , Rob Herring , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, angelo@amarulasolutions.com, michael@amarulasolutions.com, tommaso.merciai@amarulasolutions.com, Chen-Yu Tsai , linux-amarula@amarulasolutions.com, anthony@amarulasolutions.com, jagan@amarulasolutions.com, Abel Vesa , Adam Ford , Fabio Estevam , Krzysztof Kozlowski , Li Jun , Lucas Stach , Marek Vasut , Markus Niebel , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v2 11/11] arm64: dts: imx8mn: add clocks description Message-ID: References: <20230101175740.1010258-1-dario.binacchi@amarulasolutions.com> <20230101175740.1010258-12-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230101175740.1010258-12-dario.binacchi@amarulasolutions.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23-01-01 18:57:40, Dario Binacchi wrote: > The patch creates a unique node for each clock in the imx8mn clock > control module (CCM). > > To ensure backwards compatibility it was not possible to separate the > changes to the device tree from those applied to the clocks setup code. > In doing so, all clocks are initialized from the device tree and the > legacy setup code with hardwired parameters is removed. > > Signed-off-by: Dario Binacchi > > --- > > (no changes since v1) > > .../boot/dts/freescale/imx8mn-clocks.dtsi | 1885 +++++++++++++++++ > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 54 +- > drivers/clk/imx/clk-imx8mn.c | 714 ++----- > 3 files changed, 2086 insertions(+), 567 deletions(-) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-clocks.dtsi > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-clocks.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-clocks.dtsi > new file mode 100644 > index 000000000000..21e02ea996d0 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mn-clocks.dtsi > @@ -0,0 +1,1885 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Device Tree Source for imx8mn clock data > + * > + * Copyright (c) 2022 Amarula Solutions > + * > + * Dario Binacchi > + */ > + > +/ { > + osc_32k: clock-osc-32k { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + clock-output-names = "osc_32k"; > + }; > + [...] > + > + clk_audio_pll2_bypass: clock-audio-pll2-bypass@14 { > + compatible = "fsl,imx8mn-mux-clock"; > + #clock-cells = <0>; > + clocks = <&clk_audio_pll2>, <&clk_audio_pll2_ref_sel>; > + fsl,anatop = <&anatop 0x14>; > + fsl,bit-shift = <16>; > + fsl,set-rate-parent; NACK. I'm sorry, but this creates a huge effort on maintaining the bindings. Plus the vendor specific properties will keep increasing. I don't think Rob and Krzysztof will be OK with this either. > + clock-output-names = "audio_pll2_bypass"; > + }; > + > + clk_audio_pll2_out: clock-audio-pll2-out@14 { > + compatible = "fsl,imx8mn-gate-clock"; > + #clock-cells = <0>; > + clocks = <&clk_audio_pll2_bypass>; > + fsl,anatop = <&anatop 0x14>; > + fsl,bit-shift = <13>; > + clock-output-names = "audio_pll2_out"; > + }; > + [...] > -- > 2.32.0 >