From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7701CC004D4 for ; Wed, 18 Jan 2023 09:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjARJF1 (ORCPT ); Wed, 18 Jan 2023 04:05:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjARJEc (ORCPT ); Wed, 18 Jan 2023 04:04:32 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B06D538657; Wed, 18 Jan 2023 00:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674030234; x=1705566234; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uCg/XfvJ6BeR1K9GEsz6JT/fUuIQzctB031i34I0db4=; b=g42dZGJjU1P/Lz5WiJpF/nNi5/bk4Ru+oL7LsiDoihGdZtQs5fg+zKRG mDMyXLBL0zl1o+6/u8mN/6IPjRs1XOngMdP+37jLBoESvtZ66lHJ5ID6G kpENdbpj2p4VsbagixwV8FZiBLdtCj3j4ITAzuSSOUdwXGBnTPyS0f7sx v7gcuBb1k6TwvtZxfB9/999NPjOsbfwEGjHawWrnvwsG1hTBDRSlDUk7o 3hW2Ca/HnPJXh8M/BuHLRGQpQsXrUIZcl+OEwgfTYfnXwq9hI6VtK7IFz Cv0TJoRtRGgDfwp9MNTS/+c9TMftLVtYX1RFcwQlTfju5z3OhxbZ070j2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="389431277" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="389431277" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 00:23:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="833474454" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="833474454" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 18 Jan 2023 00:23:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pI3jX-00B0ki-1g; Wed, 18 Jan 2023 10:23:47 +0200 Date: Wed, 18 Jan 2023 10:23:47 +0200 From: Andy Shevchenko To: Okan Sahin Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Geert Uytterhoeven , ChiYuan Huang , Marcelo Schmitt , Marcus Folkesson , William Breathitt Gray , Ramona Bolboaca , Caleb Connolly , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH v3 5/5] drivers: iio: adc: Add ADI MAX77541 ADC Support Message-ID: References: <20230118063822.14521-1-okan.sahin@analog.com> <20230118063822.14521-6-okan.sahin@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230118063822.14521-6-okan.sahin@analog.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jan 18, 2023 at 09:38:12AM +0300, Okan Sahin wrote: > The MAX77541 has an 8-bit Successive Approximation Register (SAR) ADC > with four multiplexers for supporting the telemetry feature. ... > + * Copyright (c) 2022 Analog Devices, Inc. HNY! ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include What for these two? Make sure the list of inclusions is not semi-random. > +#include + Blank line. > +#include ... > + *val = DIV_ROUND_CLOSEST(ABSOLUTE_ZERO_MILLICELSIUS, > + 1725); This is perfectly one line, please, reduce number of LoCs by unwrapping such cases. ... > + if (ret) > + return ret; + Blank line. > + reg_val = FIELD_GET(MAX77541_BITS_MX_CFG1_RNG, reg_val); -- With Best Regards, Andy Shevchenko